tokenserver: Extract rules check into a separate function.

tokenserver: Extract rules check into a separate function.

It will be reused by MintOAuthTokenViaGrant to recheck the rules when the grant
token is exercised.

Also start using it in InspectOAuthTokenGrant, to make this check more useful.

R=smut@google.com
BUG=731843
Review-Url: https://codereview.chromium.org/2993763002
Committed: https://github.com/luci/luci-go/commit/d009bb905fb8f3f9d23f477c91039b055c0cf857

[Vadim Sh., 2017-08-05 03:27:01]

https://codereview.chromium.org/2993763002/diff/40001/tokenserver/appengine/i...
File tokenserver/appengine/impl/serviceaccounts/rpc_inspect_oauth_token_grant.go
(right):

https://codereview.chromium.org/2993763002/diff/40001/tokenserver/appengine/i...
tokenserver/appengine/impl/serviceaccounts/rpc_inspect_oauth_token_grant.go:33:
func (r *InspectOAuthTokenGrantRPC) InspectOAuthTokenGrant(c context.Context,
req *admin.InspectOAuthTokenGrantRequest)
(*admin.InspectOAuthTokenGrantResponse, error) {
Looks like this: https://screenshot.googleplex.com/3R352c3MGOK.png

[smut, 2017-08-07 21:13:45]

lgtm

[Vadim Sh., 2017-08-07 22:54:58]

The CQ bit was checked by vadimsh@chromium.org

[commit-bot: I haz the power, 2017-08-07 22:55:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-07 22:59:24]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1502146498918470,
"parent_rev": "1339415b6d85915643dab1abfa32d02248e7417a", "commit_rev":
"d009bb905fb8f3f9d23f477c91039b055c0cf857"}

[commit-bot: I haz the power, 2017-08-07 22:59:29]

Description was changed from

==========
tokenserver: Extract rules check into a separate function.

It will be reused by MintOAuthTokenViaGrant to recheck the rules when the grant
token is exercised.

Also start using it in InspectOAuthTokenGrant, to make this check more useful.

R=smut@google.com
BUG=731843
==========

to

==========
tokenserver: Extract rules check into a separate function.

It will be reused by MintOAuthTokenViaGrant to recheck the rules when the grant
token is exercised.

Also start using it in InspectOAuthTokenGrant, to make this check more useful.

R=smut@google.com
BUG=731843

Review-Url: https://codereview.chromium.org/2993763002
Committed:
https://github.com/luci/luci-go/commit/d009bb905fb8f3f9d23f477c91039b055c0cf857
==========

[commit-bot: I haz the power, 2017-08-07 22:59:30]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/d009bb905fb8f3f9d23f477c91039b055c0cf857