Issue 299353006: Buildfix for arm

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 299353006: Buildfix for arm (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 7 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Buildfix for arm TBR=jkummerow@chromium.org LOG=n BUG=none Committed: https://code.google.com/p/v8/source/detail?r=21503

Patch Set 1 #

Total comments: 2

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/utils.h	View		3 chunks	+3 lines, -3 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

Committed patchset #1 manually as r21503 (tree was closed).

6 years, 7 months ago (2014-05-26 19:43:07 UTC) #2

Jakob Kummerow

https://codereview.chromium.org/299353006/diff/1/src/utils.h File src/utils.h (right): https://codereview.chromium.org/299353006/diff/1/src/utils.h#newcode348 src/utils.h:348: extern MemCopyUint8Function memcopy_uint8_function; Before your refactoring, these guys were ...

6 years, 7 months ago (2014-05-27 07:38:46 UTC) #3

jochen (gone - plz use gerrit)

6 years, 7 months ago (2014-05-27 07:48:24 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/299353006/diff/1/src/utils.h
File src/utils.h (right):

https://codereview.chromium.org/299353006/diff/1/src/utils.h#newcode349
src/utils.h:349: void MemCopyUint8Wrapper(uint8_t* dest, const uint8_t* src,
size_t chars) {
no, I just forgot to add V8_INLINE here. I'm just building locally in qemu-arm
before uploading again.

Expand Messages | Collapse Messages