Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: src/utils.h

Issue 299353006: Buildfix for arm (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/utils.h
diff --git a/src/utils.h b/src/utils.h
index c313bfd0865dd58f79180dcbaae2013e59511178..9b520476d6dccc551ac6911c2f793fdb3645e0c0 100644
--- a/src/utils.h
+++ b/src/utils.h
@@ -345,7 +345,7 @@ V8_INLINE void MemCopy(void* dest, const void* src, size_t size) {
#elif defined(V8_HOST_ARCH_ARM)
typedef void (*MemCopyUint8Function)(uint8_t* dest, const uint8_t* src,
size_t size);
-MemCopyUint8Function memcopy_uint8_function;
+extern MemCopyUint8Function memcopy_uint8_function;
Jakob Kummerow 2014/05/27 07:38:46 Before your refactoring, these guys were marked "s
void MemCopyUint8Wrapper(uint8_t* dest, const uint8_t* src, size_t chars) {
jochen (gone - plz use gerrit) 2014/05/27 07:48:25 no, I just forgot to add V8_INLINE here. I'm just
memcpy(dest, src, chars);
}
@@ -361,7 +361,7 @@ V8_INLINE void MemMove(void* dest, const void* src, size_t size) {
typedef void (*MemCopyUint16Uint8Function)(uint16_t* dest, const uint8_t* src,
size_t size);
-MemCopyUint16Uint8Function memcopy_uint16_uint8_function;
+extern MemCopyUint16Uint8Function memcopy_uint16_uint8_function;
void MemCopyUint16Uint8Wrapper(uint16_t* dest, const uint8_t* src,
size_t chars);
// For values < 12, the assembler function is slower than the inlined C code.
@@ -373,7 +373,7 @@ V8_INLINE void MemCopyUint16Uint8(uint16_t* dest, const uint8_t* src,
#elif defined(V8_HOST_ARCH_MIPS)
typedef void (*MemCopyUint8Function)(uint8_t* dest, const uint8_t* src,
size_t size);
-MemCopyUint8Function memcopy_uint8_function;
+extern MemCopyUint8Function memcopy_uint8_function;
V8_INLINE void MemCopyUint8Wrapper(uint8_t* dest, const uint8_t* src,
size_t chars) {
memcpy(dest, src, chars);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698