Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: Source/core/editing/VisibleSelection.h

Issue 299353004: Oilpan: move editing objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased + tidied Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/VisibleSelection.h
diff --git a/Source/core/editing/VisibleSelection.h b/Source/core/editing/VisibleSelection.h
index c14630c15d700258279bc14bf5c7d10716c4e681..9294139e651613601f43267f74a3c4058eae8682 100644
--- a/Source/core/editing/VisibleSelection.h
+++ b/Source/core/editing/VisibleSelection.h
@@ -39,6 +39,7 @@ const EAffinity SEL_DEFAULT_AFFINITY = DOWNSTREAM;
enum SelectionDirection { DirectionForward, DirectionBackward, DirectionRight, DirectionLeft };
class VisibleSelection {
+ ALLOW_ONLY_INLINE_ALLOCATION();
haraken 2014/05/28 15:35:25 Just help me understand: Who uses VisibleSelection
sof 2014/05/28 22:06:06 Yes, no more than DISALLOW_ALLOCATION() is needed.
public:
VisibleSelection();
@@ -128,6 +129,8 @@ public:
void clearChangeObserver();
void didChange(); // Fire the change observer, if any.
+ void trace(Visitor*);
+
#ifndef NDEBUG
void debugPosition() const;
void formatForDebugger(char* buffer, unsigned length) const;

Powered by Google App Engine
This is Rietveld 408576698