Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Unified Diff: Source/core/editing/VisiblePosition.h

Issue 299353004: Oilpan: move editing objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased + tidied Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/VisiblePosition.h
diff --git a/Source/core/editing/VisiblePosition.h b/Source/core/editing/VisiblePosition.h
index f9f84cf02bbcba3d421a460e7e30350f6a2d7526..427c799c5a683f51a0d672d5664eb5b1c374411e 100644
--- a/Source/core/editing/VisiblePosition.h
+++ b/Source/core/editing/VisiblePosition.h
@@ -49,7 +49,8 @@ namespace WebCore {
class InlineBox;
class Node;
-class VisiblePosition {
+class VisiblePosition FINAL {
+ ALLOW_ONLY_INLINE_ALLOCATION();
haraken 2014/05/28 15:35:25 Who uses VisiblePosition in collections? Can this
sof 2014/05/28 22:06:06 No one is it turns out; don't need more than DISAL
public:
// NOTE: UPSTREAM affinity will be used only if pos is at end of a wrapped line,
// otherwise it will be converted to DOWNSTREAM
@@ -99,6 +100,8 @@ public:
// FIXME: navigation with transforms should be smarter.
int lineDirectionPointForBlockDirectionNavigation() const;
+ void trace(Visitor*);
+
#ifndef NDEBUG
void debugPosition(const char* msg = "") const;
void formatForDebugger(char* buffer, unsigned length) const;

Powered by Google App Engine
This is Rietveld 408576698