Source/core/editing/TextInsertionBaseCommand.h - Issue 299353004: Oilpan: move editing objects to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/TextInsertionBaseCommand.h

Issue 299353004: Oilpan: move editing objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased + tidied Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/editing/RemoveNodePreservingChildrenCommand.h ('K') | « Source/core/editing/SplitTextNodeContainingElementCommand.cpp ('k') | Source/core/editing/TextInsertionBaseCommand.cpp » ('j') | Source/core/editing/VisiblePosition.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/TextInsertionBaseCommand.h

diff --git a/Source/core/editing/TextInsertionBaseCommand.h b/Source/core/editing/TextInsertionBaseCommand.h

index 25baac6a74cebea6ae731394dd0fa3588fe0e9a8..4a9bd49f39afc02d5fbc3283411b7f2cf3b6fd26 100644

--- a/Source/core/editing/TextInsertionBaseCommand.h

+++ b/Source/core/editing/TextInsertionBaseCommand.h

@@ -40,7 +40,7 @@ public:

protected:

explicit TextInsertionBaseCommand(Document&);

- static void applyTextInsertionCommand(LocalFrame*, PassRefPtr<TextInsertionBaseCommand>, const VisibleSelection& selectionForInsertion, const VisibleSelection& endingSelection);

+ static void applyTextInsertionCommand(LocalFrame*, PassRefPtrWillBeRawPtr<TextInsertionBaseCommand>, const VisibleSelection& selectionForInsertion, const VisibleSelection& endingSelection);

};

String dispatchBeforeTextInsertedEvent(const String& text, const VisibleSelection& selectionForInsertion, bool insertionIsForUpdatingComposition);