Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Unified Diff: Source/core/editing/RemoveNodePreservingChildrenCommand.h

Issue 299353004: Oilpan: move editing objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased + tidied Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/RemoveNodePreservingChildrenCommand.h
diff --git a/Source/core/editing/RemoveNodePreservingChildrenCommand.h b/Source/core/editing/RemoveNodePreservingChildrenCommand.h
index 7ad1b9efaf542a94fb1e23d948577626c8087db8..898c04c77399ba5e1bdf532aa9a70af062694fe7 100644
--- a/Source/core/editing/RemoveNodePreservingChildrenCommand.h
+++ b/Source/core/editing/RemoveNodePreservingChildrenCommand.h
@@ -32,17 +32,19 @@ namespace WebCore {
class RemoveNodePreservingChildrenCommand FINAL : public CompositeEditCommand {
public:
- static PassRefPtr<RemoveNodePreservingChildrenCommand> create(PassRefPtr<Node> node, ShouldAssumeContentIsAlwaysEditable shouldAssumeContentIsAlwaysEditable)
+ static PassRefPtrWillBeRawPtr<RemoveNodePreservingChildrenCommand> create(PassRefPtrWillBeRawPtr<Node> node, ShouldAssumeContentIsAlwaysEditable shouldAssumeContentIsAlwaysEditable)
{
- return adoptRef(new RemoveNodePreservingChildrenCommand(node, shouldAssumeContentIsAlwaysEditable));
+ return adoptRefWillBeNoop(new RemoveNodePreservingChildrenCommand(node, shouldAssumeContentIsAlwaysEditable));
}
+ virtual void trace(Visitor*) OVERRIDE;
+
private:
- explicit RemoveNodePreservingChildrenCommand(PassRefPtr<Node>, ShouldAssumeContentIsAlwaysEditable);
+ explicit RemoveNodePreservingChildrenCommand(PassRefPtrWillBeRawPtr<Node>, ShouldAssumeContentIsAlwaysEditable);
haraken 2014/05/28 15:35:25 Drop explicit.
sof 2014/05/28 22:06:06 Done.
virtual void doApply() OVERRIDE;
- RefPtr<Node> m_node;
+ RefPtrWillBeMember<Node> m_node;
ShouldAssumeContentIsAlwaysEditable m_shouldAssumeContentIsAlwaysEditable;
};

Powered by Google App Engine
This is Rietveld 408576698