Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Unified Diff: Source/core/editing/UndoStack.h

Issue 299353004: Oilpan: move editing objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/UndoStack.h
diff --git a/Source/core/editing/UndoStack.h b/Source/core/editing/UndoStack.h
index 6b996cc355499313ff6d1b71a92eefddcd34d88a..eaf51382f7616b4e05c05c4b54a47c109705c9a0 100644
--- a/Source/core/editing/UndoStack.h
+++ b/Source/core/editing/UndoStack.h
@@ -31,6 +31,7 @@
#ifndef UndoStack_h
#define UndoStack_h
+#include "platform/heap/Handle.h"
#include "wtf/Deque.h"
#include "wtf/Forward.h"
@@ -45,8 +46,8 @@ public:
~UndoStack();
- void registerUndoStep(PassRefPtr<UndoStep>);
- void registerRedoStep(PassRefPtr<UndoStep>);
+ void registerUndoStep(PassRefPtrWillBeRawPtr<UndoStep>);
+ void registerRedoStep(PassRefPtrWillBeRawPtr<UndoStep>);
void didUnloadFrame(const LocalFrame&);
bool canUndo() const;
bool canRedo() const;
@@ -58,7 +59,7 @@ private:
bool m_inRedo;
- typedef Deque<RefPtr<UndoStep> > UndoStepStack;
+ typedef WillBePersistentHeapDeque<RefPtrWillBeMember<UndoStep> > UndoStepStack;
haraken 2014/05/26 02:36:12 Shall we avoid using typedef for persistent collec
zerny-chromium 2014/05/26 07:51:08 In other places we have used a typedef pair to avo
sof 2014/05/28 08:31:35 Followed that.
void filterOutUndoSteps(UndoStepStack&, const LocalFrame&);
UndoStepStack m_undoStack;
UndoStepStack m_redoStack;

Powered by Google App Engine
This is Rietveld 408576698