Oilpan: move editing objects to the heap.

Source/core/editing/UndoStack.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef UndoStack_h
 #define UndoStack_h
 
+#include "platform/heap/Handle.h"
 #include "wtf/Deque.h"
 #include "wtf/Forward.h"
 
 namespace WebCore {
 
 class LocalFrame;
 class UndoStep;
 
 class UndoStack {
 public:
     static PassOwnPtr<UndoStack> create();
 
     ~UndoStack();
 
-    void registerUndoStep(PassRefPtr<UndoStep>);
-    void registerRedoStep(PassRefPtr<UndoStep>);
+    void registerUndoStep(PassRefPtrWillBeRawPtr<UndoStep>);
+    void registerRedoStep(PassRefPtrWillBeRawPtr<UndoStep>);
     void didUnloadFrame(const LocalFrame&);
     bool canUndo() const;
     bool canRedo() const;
     void undo();
     void redo();
 
 private:
     UndoStack();
 
     bool m_inRedo;
 
-    typedef Deque<RefPtr<UndoStep> > UndoStepStack;
+    typedef WillBePersistentHeapDeque<RefPtrWillBeMember<UndoStep> > UndoStepStack;

[haraken, 2014/05/26 02:36:12]

Shall we avoid using typedef for persistent collections? It's easy to use it in
places where persistent handles shouldn't be used (e.g., see my comment in
UndoStack.cpp.)

[zerny-chromium, 2014/05/26 07:51:08]

In other places we have used a typedef pair to avoid hidden persistents:

typedef WillBePersistentHeapFoo PersistentFoo
typedef WillBeHeapFoo Foo

[sof, 2014/05/28 08:31:35]

Followed that.

     void filterOutUndoSteps(UndoStepStack&, const LocalFrame&);
     UndoStepStack m_undoStack;
     UndoStepStack m_redoStack;
 };
 
 } // namespace WebCore
 
 #endif