Oilpan: move editing objects to the heap.

Source/core/editing/MarkupAccumulator.h

Index: Source/core/editing/MarkupAccumulator.h
diff --git a/Source/core/editing/MarkupAccumulator.h b/Source/core/editing/MarkupAccumulator.h
index fdbed0151df9108cb1b8c9ff947e687ec64c149f..0fbbd65efd5ba91fb5f5a2a056e71803bafc0ce0 100644
--- a/Source/core/editing/MarkupAccumulator.h
+++ b/Source/core/editing/MarkupAccumulator.h
@@ -64,9 +64,9 @@ enum SerializationType {
 
 class MarkupAccumulator {
     WTF_MAKE_NONCOPYABLE(MarkupAccumulator);
-
+    STACK_ALLOCATED();
 public:
-    MarkupAccumulator(Vector<Node*>*, EAbsoluteURLs, const Range* = 0, SerializationType = AsOwnerDocument);
+    MarkupAccumulator(WillBeHeapVector<RawPtrWillBeMember<Node> >*, EAbsoluteURLs, RawPtr<const Range> = nullptr, SerializationType = AsOwnerDocument);

[zerny-chromium, 2014/05/26 07:51:08]

Nit: Do we need to change Range* to RawPtr<Range>?

[sof, 2014/05/28 08:31:35]

Because it'll soon be a Range* again? :) No, no good reason beyond trying to
consistently use RawPtr<>.

Switched back.

     virtual ~MarkupAccumulator();
 
     String serializeNodes(Node& targetNode, EChildrenOnly, Vector<QualifiedName>* tagNamesToSkip = 0);
@@ -103,8 +103,8 @@ protected:
     bool elementCannotHaveEndTag(const Node&);
     void appendEndMarkup(StringBuilder&, const Node&);
 
-    Vector<Node*>* const m_nodes;
-    const Range* const m_range;
+    WillBeHeapVector<RawPtrWillBeMember<Node> >* const m_nodes;

[haraken, 2014/05/26 02:36:12]

Shall we use RawPtrWillBeMember<WillBeHeapVector<RawPtrWillBeMember<Node> >> ?

[sof, 2014/05/28 08:31:35]

It shouldn't make a difference wrt stack scanning, but no good reason not to.

+    RawPtrWillBeMember<const Range> const m_range;
 
 private:
     String resolveURLIfNeeded(const Element&, const String&) const;