Oilpan: move editing objects to the heap.

Source/core/editing/MarkupAccumulator.h

 /*
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 46 matching lines @@
     EntityMaskInHTMLAttributeValue = EntityAmp | EntityQuot | EntityNbsp,
 };
 
 enum SerializationType {
     AsOwnerDocument,
     ForcedXML
 };
 
 class MarkupAccumulator {
     WTF_MAKE_NONCOPYABLE(MarkupAccumulator);
-
+    STACK_ALLOCATED();
 public:
-    MarkupAccumulator(Vector<Node*>*, EAbsoluteURLs, const Range* = 0, SerializationType = AsOwnerDocument);
+    MarkupAccumulator(WillBeHeapVector<RawPtrWillBeMember<Node> >*, EAbsoluteURLs, RawPtr<const Range> = nullptr, SerializationType = AsOwnerDocument);

[zerny-chromium, 2014/05/26 07:51:08]

Nit: Do we need to change Range* to RawPtr<Range>?

[sof, 2014/05/28 08:31:35]

Because it'll soon be a Range* again? :) No, no good reason beyond trying to
consistently use RawPtr<>.

Switched back.

     virtual ~MarkupAccumulator();
 
     String serializeNodes(Node& targetNode, EChildrenOnly, Vector<QualifiedName>* tagNamesToSkip = 0);
 
     static void appendComment(StringBuilder&, const String&);
 
     static void appendCharactersReplacingEntities(StringBuilder&, const String&, unsigned, unsigned, EntityMask);
 
 protected:
     void appendString(const String&);
@@ skipping 16 matching lines @@
     virtual void appendElement(StringBuilder&, Element&, Namespaces*);
     void appendOpenTag(StringBuilder&, const Element&, Namespaces*);
     void appendCloseTag(StringBuilder&, const Element&);
     void appendAttribute(StringBuilder&, const Element&, const Attribute&, Namespaces*);
     void appendCDATASection(StringBuilder&, const String&);
     void appendStartMarkup(StringBuilder&, Node&, Namespaces*);
     bool shouldSelfClose(const Node&);
     bool elementCannotHaveEndTag(const Node&);
     void appendEndMarkup(StringBuilder&, const Node&);
 
-    Vector<Node*>* const m_nodes;
-    const Range* const m_range;
+    WillBeHeapVector<RawPtrWillBeMember<Node> >* const m_nodes;

[haraken, 2014/05/26 02:36:12]

Shall we use RawPtrWillBeMember<WillBeHeapVector<RawPtrWillBeMember<Node> >> ?

[sof, 2014/05/28 08:31:35]

It shouldn't make a difference wrt stack scanning, but no good reason not to.

+    RawPtrWillBeMember<const Range> const m_range;
 
 private:
     String resolveURLIfNeeded(const Element&, const String&) const;
     void appendQuotedURLAttributeValue(StringBuilder&, const Element&, const Attribute&);
     void serializeNodesWithNamespaces(Node& targetNode, EChildrenOnly, const Namespaces*, Vector<QualifiedName>* tagNamesToSkip);
     bool serializeAsHTMLDocument(const Node&) const;
 
     StringBuilder m_markup;
     const EAbsoluteURLs m_resolveURLsMethod;
     SerializationType m_serializationType;
 };
 
 }
 
 #endif