Fix dartbug.com/18725 by avoiding to rewrite into the console at process

Fix dartbug.com/18725 by avoiding to rewrite into the console at process
launch time (writes apparently appear on the stdin of the launched process).

This is not necessarily the fix you want to go with, but I thought I'd send it your
way because it fixes the (pretty bad) issue that puts extra stuff on the stdin for
processes. I also like that the output from the process is cleanly separated from
the editor UI bits (showing the cmdline). Ideally, we can also make the Observatory
print (from the VM) go away so the output in the console is completely under the
app's control.

R=devoncarew@google.com, keertip@google.com
BUG=dartbug.com/18725

Committed: https://code.google.com/p/dart/source/detail?r=36643

[devoncarew, 2014-05-26 18:10:38]

lgtm

Thanks for the fix! lgtm, with one suggested change.

https://codereview.chromium.org/299323004/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/console/DartConsoleView.java
(left):

https://codereview.chromium.org/299323004/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/console/DartConsoleView.java:201:
private static final String NEW_LINE = System.getProperty("line.separator");
I believe this can also be removed.

https://codereview.chromium.org/299323004/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/console/DartConsoleView.java
(right):

https://codereview.chromium.org/299323004/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/console/DartConsoleView.java:510:
setContentDescription(name + " | " + cmdline);
I think that showing the full command line in the description area will be more
verbose then we want. Can you change this to just setContentDescription(name)?
We have some other places where we show the user the command line. I don't think
it's necessary for them to see it printed out each time they run the
application.

[kasperl, 2014-05-27 06:35:08]

Thanks for the review!

https://codereview.chromium.org/299323004/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/console/DartConsoleView.java
(left):

https://codereview.chromium.org/299323004/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/console/DartConsoleView.java:201:
private static final String NEW_LINE = System.getProperty("line.separator");
On 2014/05/26 18:10:39, devoncarew wrote:
> I believe this can also be removed.

Done.

https://codereview.chromium.org/299323004/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/console/DartConsoleView.java
(right):

https://codereview.chromium.org/299323004/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/console/DartConsoleView.java:510:
setContentDescription(name + " | " + cmdline);
On 2014/05/26 18:10:39, devoncarew wrote:
> I think that showing the full command line in the description area will be
more
> verbose then we want. Can you change this to just setContentDescription(name)?
> We have some other places where we show the user the command line. I don't
think
> it's necessary for them to see it printed out each time they run the
> application.

Done.

[kasperl, 2014-05-27 06:36:25]

Committed patchset #2 manually as r36643 (presubmit successful).