Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2993173002: Fix an ownership issue in ScopedAgentLogger (Closed)

Created:
3 years, 4 months ago by Sébastien Marchand
Modified:
3 years, 4 months ago
Reviewers:
chrisha
CC:
syzygy-changes_googlegroups.com, njanevsk
Target Ref:
refs/heads/master
Project:
syzygy
Visibility:
Public.

Description

Fix an ownership issue in ScopedAgentLogger The temporary directory used by the ScopedAgentLogger class shouldn't be cleaned up on destruction as it's owned by the object that owns this logger's instance. This is a part of the integration_test's design as we need to process the logger files after it has been destroyed (i.e. to analyze the minidump). Review-Url: https://codereview.chromium.org/2993173002 Committed: https://github.com/google/syzygy/commit/3c81c059f6e414ce979c5654fd88699f8835e89b

Patch Set 1 #

Patch Set 2 : Fix an ownership issue in ScopedAgentLogger #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M syzygy/integration_tests/instrument_integration_test.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Sébastien Marchand
PTAL.
3 years, 4 months ago (2017-08-07 17:09:43 UTC) #2
Sébastien Marchand
ping?
3 years, 4 months ago (2017-08-08 20:33:02 UTC) #3
chrisha
lgtm
3 years, 4 months ago (2017-08-09 21:29:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2993173002/20001
3 years, 4 months ago (2017-08-09 21:29:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2993173002/20001
3 years, 4 months ago (2017-08-09 21:29:46 UTC) #8
commit-bot: I haz the power
3 years, 4 months ago (2017-08-09 22:29:08 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/google/syzygy/commit/3c81c059f6e414ce979c5654fd88699f8835e89b

Powered by Google App Engine
This is Rietveld 408576698