Eliminate dependencies on pkg/front_end.

Eliminate dependencies on pkg/front_end.

The API for pkg/front_end is still in flux so we want to avoid having
any packages depend directly on it (other than analyzer and
back-ends).

This CL re-exports some of the critical pieces of front_end needed by
analyzer clients so that those clients can access them via analyzer,
without having to directly depend on front_end.  It also updates
pkg/analyzer_plugin to make use of those re-exports.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/e2f77056a54f5c1ce07ce906fda95863eef70dcf

[Paul Berry, 2017-08-04 22:54:00]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com, sigmund@google.com

[scheglov, 2017-08-04 22:56:55]

LGTM

[Paul Berry, 2017-08-07 16:46:34]

Description was changed from

==========
Eliminate dependencies on pkg/front_end.

The API for pkg/front_end is still in flux so we want to avoid having
any packages depend directly on it (other than analyzer and
back-ends).

This CL re-exports some of the critical pieces of front_end needed by
analyzer clients so that those clients can access them via analyzer,
without having to directly depend on front_end.  It also updates
pkg/analyzer_plugin to make use of those re-exports.
==========

to

==========
Eliminate dependencies on pkg/front_end.

The API for pkg/front_end is still in flux so we want to avoid having
any packages depend directly on it (other than analyzer and
back-ends).

This CL re-exports some of the critical pieces of front_end needed by
analyzer clients so that those clients can access them via analyzer,
without having to directly depend on front_end.  It also updates
pkg/analyzer_plugin to make use of those re-exports.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e2f77056a54f5c1ce07ce906fda95863eef70dcf
==========

[Paul Berry, 2017-08-07 16:46:36]

Committed patchset #1 (id:1) manually as
e2f77056a54f5c1ce07ce906fda95863eef70dcf (presubmit successful).

[Siggi Cherem (dart-lang), 2017-08-07 16:57:10]

lgtm

https://codereview.chromium.org/2993123002/diff/1/pkg/analyzer/lib/src/codege...
File pkg/analyzer/lib/src/codegen/tools.dart (right):

https://codereview.chromium.org/2993123002/diff/1/pkg/analyzer/lib/src/codege...
pkg/analyzer/lib/src/codegen/tools.dart:13: export
'package:front_end/src/codegen/tools.dart';
it seems like this file is not used anymore in pacakge:front_end, maybe it is
worth moving that code back here?

https://codereview.chromium.org/2993123002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/byte_store.dart (right):

https://codereview.chromium.org/2993123002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/byte_store.dart:9: show ByteStore,
MemoryByteStore, MemoryCachingByteStore;
not now, but would it make sense to eventually move these to a separate package?

For now, should we move them to a different folder to make sure in our
subpacakge_tests cover that we never import fasta from these files? (that way we
ensure we don't expose indirectly internal types that are in more flux)?

[Paul Berry, 2017-08-07 17:04:34]

https://codereview.chromium.org/2993123002/diff/1/pkg/analyzer/lib/src/codege...
File pkg/analyzer/lib/src/codegen/tools.dart (right):

https://codereview.chromium.org/2993123002/diff/1/pkg/analyzer/lib/src/codege...
pkg/analyzer/lib/src/codegen/tools.dart:13: export
'package:front_end/src/codegen/tools.dart';
On 2017/08/07 16:57:10, Siggi Cherem (dart-lang) wrote:
> it seems like this file is not used anymore in pacakge:front_end, maybe it is
> worth moving that code back here?

Maybe.  I'd like to wait until we see how kernel's use of flatbuffers pans out
first.

https://codereview.chromium.org/2993123002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/byte_store.dart (right):

https://codereview.chromium.org/2993123002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/byte_store.dart:9: show ByteStore,
MemoryByteStore, MemoryCachingByteStore;
On 2017/08/07 16:57:10, Siggi Cherem (dart-lang) wrote:
> not now, but would it make sense to eventually move these to a separate
package?
> 
> For now, should we move them to a different folder to make sure in our
> subpacakge_tests cover that we never import fasta from these files? (that way
we
> ensure we don't expose indirectly internal types that are in more flux)?

Sure, I'll do that as a follow-up CL.