pkg/analyzer/lib/src/dart/analysis/byte_store.dart - Issue 2993123002: Eliminate dependencies on pkg/front_end.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: pkg/analyzer/lib/src/dart/analysis/byte_store.dart

Issue 2993123002: Eliminate dependencies on pkg/front_end. (Closed)

Patch Set: Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file

	2 // for details. All rights reserved. Use of this source code is governed by a

	3 // BSD-style license that can be found in the LICENSE file.

	4

	5 // This library re-exports the parts of front_end's byte_store.dart whose API is

	6 // stable enough to be relied upon by clients.

	7

	8 export 'package:front_end/src/incremental/byte_store.dart'

	9 show ByteStore, MemoryByteStore, MemoryCachingByteStore;
	Siggi Cherem (dart-lang) 2017/08/07 16:57:10 not now, but would it make sense to eventually mov not now, but would it make sense to eventually move these to a separate package? For now, should we move them to a different folder to make sure in our subpacakge_tests cover that we never import fasta from these files? (that way we ensure we don't expose indirectly internal types that are in more flux)? Paul Berry 2017/08/07 17:04:33 Sure, I'll do that as a follow-up CL. Show quoted text On 2017/08/07 16:57:10, Siggi Cherem (dart-lang) wrote: > not now, but would it make sense to eventually move these to a separate package? > > For now, should we move them to a different folder to make sure in our > subpacakge_tests cover that we never import fasta from these files? (that way we > ensure we don't expose indirectly internal types that are in more flux)? Sure, I'll do that as a follow-up CL.
OLD	NEW