Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2992903002: Fix a couple of things causing bot redness: (Closed)

Created:
3 years, 4 months ago by Bob Nystrom
Modified:
3 years, 4 months ago
Reviewers:
jcollins
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a couple of things causing bot redness: - Migrate over built_in_identifier_test since it imports a helper library that was migrated. - Fix some status file entries. Also: - Removed some old commented out status entries. - Fix a bug in migration script. R=jcollins@google.com Committed: https://github.com/dart-lang/sdk/commit/dbd48de07d9ec5db1565b793867a33656bf022ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -484 lines) Patch
D tests/language/built_in_identifier_test.dart View 1 chunk +0 lines, -116 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -2 lines 0 comments Download
A + tests/language_2/built_in_identifier_prefix_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/built_in_identifier_test.dart View 7 chunks +24 lines, -24 lines 0 comments Download
M tests/language_2/language_2.status View 2 chunks +14 lines, -10 lines 0 comments Download
D tests/language_strong/built_in_identifier_prefix_test.dart View 1 chunk +0 lines, -216 lines 0 comments Download
D tests/language_strong/built_in_identifier_test.dart View 1 chunk +0 lines, -116 lines 0 comments Download
M tools/migration/lib/src/fork.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Bob Nystrom
3 years, 4 months ago (2017-08-02 21:46:53 UTC) #2
jcollins
LGTM Might be safer next time to fix the bots separately, but OK
3 years, 4 months ago (2017-08-02 21:52:28 UTC) #3
Bob Nystrom
Committed patchset #1 (id:1) manually as dbd48de07d9ec5db1565b793867a33656bf022ca.
3 years, 4 months ago (2017-08-02 21:54:12 UTC) #5
Bob Nystrom
3 years, 4 months ago (2017-08-02 21:54:59 UTC) #6
Message was sent while issue was closed.
On 2017/08/02 21:52:28, jcollins wrote:
> LGTM
> 
> Might be safer next time to fix the bots separately, but OK

Yeah, sorry the CL was sort of a grab bag. I try to do things more separately
usually, but I was in a hurry and the changes were all pretty small. :-/

Powered by Google App Engine
This is Rietveld 408576698