Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: tests/language_2/language_2.status

Issue 2992903002: Fix a couple of things causing bot redness: (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/language_2/language_2.status
diff --git a/tests/language_2/language_2.status b/tests/language_2/language_2.status
index e059127aa2bc538f8962c03bda8b60e150f916b1..3fbb1f347c1222e6d4d0cde9d1d6aaf14cd7eb99 100644
--- a/tests/language_2/language_2.status
+++ b/tests/language_2/language_2.status
@@ -566,6 +566,8 @@ bound_closure_equality_test: Crash
bound_closure_primitives_test: Crash
branch_canonicalization_test: RuntimeError
break_test: Crash
+built_in_identifier_test/01: Crash
+built_in_identifier_test/none: Crash
[ $compiler == dart2js && $runtime != none && $checked ]
assert_with_message_test: RuntimeError
@@ -686,20 +688,22 @@ async_star_no_cancel_test: Skip # Flutter Issue 9110
bool_check_test: RuntimeError # Issue 29647
bool_condition_check_test: RuntimeError
+[ $compiler == precompiler && $runtime == dart_precompiled ]
+bool_check_test: RuntimeError
+
[ $compiler == dart2analyzer ]
bad_initializer2_negative_test: fail # Issue 14880
black_listed_test/none: fail # Issue 14228
bad_initializer1_negative_test: CompileTimeError # Issue 14529
bad_named_constructor_negative_test: CompileTimeError # Issue 18693
body_less_constructor_wrong_arg_negative_test: CompileTimeError # Issue 18695
+built_in_identifier_prefix_test: CompileTimeError
+
+[ $runtime == vm ]
+built_in_identifier_prefix_test: CompileTimeError
-[ $strong ]
-#bad_constructor_test: Skip
-#bad_initializer1_negative_test: Skip
-#bad_initializer2_negative_test: Skip
-#bad_named_constructor_negative_test: Skip
-#bad_named_parameters2_test: Skip
-#bad_named_parameters_test: Skip
-#bad_override_test: Skip
-#black_listed_test: Skip
-#body_less_constructor_wrong_arg_negative_test: Skip
+[ $compiler == dart2js ]
+built_in_identifier_prefix_test: CompileTimeError
+
+[ $compiler == dartdevc ]
+built_in_identifier_prefix_test: CompileTimeError
« no previous file with comments | « tests/language_2/built_in_identifier_test.dart ('k') | tests/language_strong/built_in_identifier_prefix_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698