Support forEachClassMember on closure classes

Support forEachClassMember on closure classes

+ split MemberData into MemberData interface and MemberDataImpl node based implementation and add ClosureMemberData objects
+ use SourceSpan instead of ir.Location for Class/MemberDefinition.location
+ register StaticUse.callMethod instead of StaticUse.closure
+ use DartType instead of ResolutionDartType in metadata_collector

R=efortuna@google.com

Committed: https://github.com/dart-lang/sdk/commit/476b1cdd44a57bcfa1567997abaf3bd180271c5d

[Johnni Winther, 2017-08-02 12:51:59]

Description was changed from

==========
Support forEachClassMember on closure classes

+ split MemberData into MemberData interfae and MemberDataImpl node based
implementation and add ClosureMemberData objects
+ use SourceSpan instead of ir.Location for Class/MemberDefinition.location
+ register StaticUse.callMethod instead of StaticUse.closure
+ use DartType instead of ResolutionDartType in metadata_collector
==========

to

==========
Support forEachClassMember on closure classes

+ split MemberData into MemberData interface and MemberDataImpl node based
implementation and add ClosureMemberData objects
+ use SourceSpan instead of ir.Location for Class/MemberDefinition.location
+ register StaticUse.callMethod instead of StaticUse.closure
+ use DartType instead of ResolutionDartType in metadata_collector
==========

[Johnni Winther, 2017-08-02 12:52:10]

johnniwinther@google.com changed reviewers:
+ efortuna@google.com

[Emily Fortuna, 2017-08-02 17:49:55]

cool! We'll need to update several status files with this change (yay!). I made
a patch to show what needs to be modified:
https://codereview.chromium.org/2993603002/

https://codereview.chromium.org/2992863002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/metadata_collector.dart (right):

https://codereview.chromium.org/2992863002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/metadata_collector.dart:26: show
ResolutionDartType, ResolutionTypedefType;
you can remove ResolutionDartType here then.

[Emily Fortuna, 2017-08-02 17:50:34]

oh, and lgtm

[Johnni Winther, 2017-08-03 08:53:30]

Patchset #3 (id:40001) has been deleted

[Johnni Winther, 2017-08-03 08:58:34]

https://codereview.chromium.org/2992863002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/metadata_collector.dart (right):

https://codereview.chromium.org/2992863002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/metadata_collector.dart:26: show
ResolutionDartType, ResolutionTypedefType;
On 2017/08/02 17:49:55, Emily Fortuna wrote:
> you can remove ResolutionDartType here then.

Done.

[Johnni Winther, 2017-08-03 08:59:26]

Description was changed from

==========
Support forEachClassMember on closure classes

+ split MemberData into MemberData interface and MemberDataImpl node based
implementation and add ClosureMemberData objects
+ use SourceSpan instead of ir.Location for Class/MemberDefinition.location
+ register StaticUse.callMethod instead of StaticUse.closure
+ use DartType instead of ResolutionDartType in metadata_collector
==========

to

==========
Support forEachClassMember on closure classes

+ split MemberData into MemberData interface and MemberDataImpl node based
implementation and add ClosureMemberData objects
+ use SourceSpan instead of ir.Location for Class/MemberDefinition.location
+ register StaticUse.callMethod instead of StaticUse.closure
+ use DartType instead of ResolutionDartType in metadata_collector

R=efortuna@google.com

Committed:
https://github.com/dart-lang/sdk/commit/476b1cdd44a57bcfa1567997abaf3bd180271c5d
==========

[Johnni Winther, 2017-08-03 08:59:27]

Committed patchset #2 (id:20001) manually as
476b1cdd44a57bcfa1567997abaf3bd180271c5d (presubmit successful).