Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: pkg/compiler/lib/src/js_emitter/metadata_collector.dart

Issue 2992863002: Support forEachClassMember on closure classes (Closed)
Patch Set: Updated cf. comments Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_backend/impact_transformer.dart ('k') | pkg/compiler/lib/src/js_model/closure.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_emitter/metadata_collector.dart
diff --git a/pkg/compiler/lib/src/js_emitter/metadata_collector.dart b/pkg/compiler/lib/src/js_emitter/metadata_collector.dart
index 8ba3d0ad9d5815693980eefdbdf68f1c87d54d9b..fcddb202ab330a0b55c2f007b52e1bd3aabe65a7 100644
--- a/pkg/compiler/lib/src/js_emitter/metadata_collector.dart
+++ b/pkg/compiler/lib/src/js_emitter/metadata_collector.dart
@@ -22,8 +22,7 @@ import '../elements/elements.dart'
MetadataAnnotation,
ParameterElement;
import '../elements/entities.dart';
-import '../elements/resolution_types.dart'
- show ResolutionDartType, ResolutionTypedefType;
+import '../elements/resolution_types.dart' show ResolutionTypedefType;
import '../elements/types.dart';
import '../js/js.dart' as jsAst;
import '../js/js.dart' show js;
@@ -167,8 +166,8 @@ class MetadataCollector implements jsAst.TokenFinalizer {
}
/// A map used to canonicalize the entries of types.
- Map<OutputUnit, Map<ResolutionDartType, _BoundMetadataEntry>> _typesMap =
- <OutputUnit, Map<ResolutionDartType, _BoundMetadataEntry>>{};
+ Map<OutputUnit, Map<DartType, _BoundMetadataEntry>> _typesMap =
+ <OutputUnit, Map<DartType, _BoundMetadataEntry>>{};
MetadataCollector(
this._options,
@@ -333,8 +332,7 @@ class MetadataCollector implements jsAst.TokenFinalizer {
ignoreTypeVariables: ignoreTypeVariables);
}
- jsAst.Expression reifyTypeForOutputUnit(
- ResolutionDartType type, OutputUnit outputUnit,
+ jsAst.Expression reifyTypeForOutputUnit(DartType type, OutputUnit outputUnit,
{ignoreTypeVariables: false}) {
return addTypeInOutputUnit(type, outputUnit,
ignoreTypeVariables: ignoreTypeVariables);
@@ -361,7 +359,7 @@ class MetadataCollector implements jsAst.TokenFinalizer {
});
}
- jsAst.Expression _computeTypeRepresentation(ResolutionDartType type,
+ jsAst.Expression _computeTypeRepresentation(DartType type,
{ignoreTypeVariables: false}) {
jsAst.Expression representation =
_rtiEncoder.getTypeRepresentation(_emitter, type, (variable) {
@@ -381,12 +379,10 @@ class MetadataCollector implements jsAst.TokenFinalizer {
return representation;
}
- jsAst.Expression addTypeInOutputUnit(
- ResolutionDartType type, OutputUnit outputUnit,
+ jsAst.Expression addTypeInOutputUnit(DartType type, OutputUnit outputUnit,
{ignoreTypeVariables: false}) {
if (_typesMap[outputUnit] == null) {
- _typesMap[outputUnit] =
- new Map<ResolutionDartType, _BoundMetadataEntry>();
+ _typesMap[outputUnit] = new Map<DartType, _BoundMetadataEntry>();
}
return _typesMap[outputUnit].putIfAbsent(type, () {
return new _BoundMetadataEntry(_computeTypeRepresentation(type,
« no previous file with comments | « pkg/compiler/lib/src/js_backend/impact_transformer.dart ('k') | pkg/compiler/lib/src/js_model/closure.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698