Issue 2992783002: [vm] Rename Integer::IsValidUint64 to IsValueInRange for clarity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2992783002: [vm] Rename Integer::IsValidUint64 to IsValueInRange for clarity (Closed)

Created:
3 years, 4 months ago by alexmarkov

Modified:
3 years, 4 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

[vm] Rename Integer::IsValidUint64 to IsValueInRange for clarity This is a follow-up for the 41fb3c6d16f1d466d4e7968c2c677c415c397d7c. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/d3e5ee698173fb2890656d59246858de51b9b0af

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	runtime/vm/dart_api_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

alexmarkov

3 years, 4 months ago (2017-08-01 15:30:53 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d3e5ee698173fb2890656d59246858de51b9b0af (presubmit successful).