runtime/vm/dart_api_impl.cc - Issue 2992783002: [vm] Rename Integer::IsValidUint64 to IsValueInRange for clarity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 2992783002: [vm] Rename Integer::IsValidUint64 to IsValueInRange for clarity (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/dart_api_impl.cc

diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc

index e17c1b20338b42a68b3a5680415ff78eec97cbf8..8d440bcf0364edddb1fd2cc3a917eed460d94eb1 100644

--- a/runtime/vm/dart_api_impl.cc

+++ b/runtime/vm/dart_api_impl.cc

@@ -2090,7 +2090,7 @@ DART_EXPORT Dart_Handle Dart_NewIntegerFromUint64(uint64_t value) {

DARTSCOPE(Thread::Current());

CHECK_CALLBACK_STATE(T);

API_TIMELINE_DURATION;

- if (Integer::IsValidUint64(value)) {

+ if (Integer::IsValueInRange(value)) {

return Api::NewHandle(T, Integer::NewFromUint64(value));

}

return Api::NewError("%s: Cannot create Dart integer from value %" Pu64,

« no previous file with comments | « no previous file | runtime/vm/object.h » ('j') | no next file with comments »