Issue 299273003: Revert 272587 "Remove kEnablePrintPreview now that the pdf plugi..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 299273003: Revert 272587 "Remove kEnablePrintPreview now that the pdf plugi..." (Closed)

Created:
6 years, 7 months ago by fgorski

Modified:
6 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 272587 "Remove kEnablePrintPreview now that the pdf plugi..." Reverting bacuse of failure of ClosingWindowWhilePrintingShouldNotCrash after it was enabled by this change on Linux Tests. > Remove kEnablePrintPreview now that the pdf plugin is part of Chromium. > > R=thestig@chromium.org > > Review URL: https://codereview.chromium.org/296453015 TBR=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272622

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+104 lines, -11 lines)			Patch
M	trunk/src/chrome/browser/apps/app_browsertest.cc	View	3 chunks	+27 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/prefs/command_line_pref_store.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/profiles/profile_impl.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/common/chrome_switches.h	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	trunk/src/chrome/common/chrome_switches.cc	View	2 chunks	+12 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/test/data/webui/print_preview.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/test/data/webui/print_preview.cc	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	trunk/src/tools/bisect-builds.py	View	9 chunks	+21 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r272622.