Issue 296453015: Remove kEnablePrintPreview now that the pdf plugin is part of Chromium.

Issue 296453015: Remove kEnablePrintPreview now that the pdf plugin is part of Chromium. (Closed)

Created:
6 years, 7 months ago by jam

Modified:
6 years, 6 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove kEnablePrintPreview now that the pdf plugin is part of Chromium. R=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272587 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272972

Patch Set 4 : reupload after revert #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -104 lines)			Patch
M	chrome/browser/apps/app_browsertest.cc	View	1 2 3	3 chunks	+3 lines, -27 lines	0 comments	Download
M	chrome/browser/prefs/command_line_pref_store.cc	View	1 2 3	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/printing/print_preview_dialog_controller_browsertest.cc	View	1 2 3	2 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/profiles/profile_impl.cc	View	1 2 3	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc	View	1 2 3	3 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 2 3	2 chunks	+1 line, -6 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 2 3	2 chunks	+3 lines, -12 lines	0 comments	Download
M	chrome/test/data/webui/print_preview.h	View	1 2 3	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/test/data/webui/print_preview.cc	View	1 2 3	1 chunk	+0 lines, -11 lines	0 comments	Download
M	tools/bisect-builds.py	View	1 2 3	9 chunks	+4 lines, -21 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

lgtm https://codereview.chromium.org/296453015/diff/2/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc File chrome/browser/printing/print_preview_dialog_controller_browsertest.cc (right): https://codereview.chromium.org/296453015/diff/2/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc#newcode5 chrome/browser/printing/print_preview_dialog_controller_browsertest.cc:5: #include "base/command_line.h" you can also remove this and ...

6 years, 7 months ago (2014-05-21 19:07:53 UTC) #3

jam

https://codereview.chromium.org/296453015/diff/2/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc File chrome/browser/printing/print_preview_dialog_controller_browsertest.cc (right): https://codereview.chromium.org/296453015/diff/2/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc#newcode5 chrome/browser/printing/print_preview_dialog_controller_browsertest.cc:5: #include "base/command_line.h" On 2014/05/21 19:07:53, Lei Zhang wrote: > ...

6 years, 7 months ago (2014-05-21 19:31:06 UTC) #5

jam

6 years, 7 months ago (2014-05-23 14:41:30 UTC) #6

Lei: I've had to modify chrome/browser/profiles/profile_impl.cc like your other
cl you sent me to make the tests pass; ptal.

Expand Messages | Collapse Messages