Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 2992713002: config_service: add ref config set type (Closed)

Created:
3 years, 4 months ago by ayanaadylova
Modified:
3 years, 4 months ago
Reviewers:
Sergey Berezin, hinoka
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Nit: check for /refs instead of just refs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M appengine/config_service/ui/src/config-ui/config-set.html View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
ayanaadylova
PTAL
3 years, 4 months ago (2017-07-28 20:57:09 UTC) #2
Sergey Berezin
LGTM, thanks!
3 years, 4 months ago (2017-07-31 18:43:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2992713002/20001
3 years, 4 months ago (2017-07-31 19:01:39 UTC) #6
commit-bot: I haz the power
3 years, 4 months ago (2017-07-31 19:04:43 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/b885c44dc816754a8f1679664b05142762ecd303

Powered by Google App Engine
This is Rietveld 408576698