Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2992693002: isolate: add uploadtracker tests for symlinks and isolated files (Closed)

Created:
3 years, 4 months ago by mcgreevy
Modified:
3 years, 4 months ago
Reviewers:
mithro
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

isolate: add uploadtracker tests for symlinks and isolated files BUG=692940 Review-Url: https://codereview.chromium.org/2992693002 Committed: https://github.com/luci/luci-go/commit/7875602af13ed009f3e609f698fb7aba3b1787df

Patch Set 1 #

Patch Set 2 : isolate: add uploadtracker_tests for symlinks and isolated files #

Total comments: 2

Patch Set 3 : address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+332 lines, -31 lines) Patch
M client/cmd/isolate/checker.go View 6 chunks +17 lines, -10 lines 0 comments Download
M client/cmd/isolate/upload_tracker.go View 6 chunks +45 lines, -8 lines 0 comments Download
A client/cmd/isolate/upload_tracker_test.go View 1 chunk +248 lines, -0 lines 0 comments Download
M client/cmd/isolate/uploader.go View 1 2 7 chunks +22 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
mcgreevy
3 years, 4 months ago (2017-07-28 06:38:52 UTC) #3
mithro
LGTM. Having tests for this code is awesome! Only question was why it was called ...
3 years, 4 months ago (2017-07-31 02:34:26 UTC) #4
mcgreevy
https://codereview.chromium.org/2992693002/diff/20001/client/cmd/isolate/uploader.go File client/cmd/isolate/uploader.go (right): https://codereview.chromium.org/2992693002/diff/20001/client/cmd/isolate/uploader.go#newcode39 client/cmd/isolate/uploader.go:39: // CappedUploader uses an isolatedclient.Client to upload items to ...
3 years, 4 months ago (2017-07-31 04:42:12 UTC) #5
mithro
On 2017/07/31 04:42:12, mcgreevy wrote: > https://codereview.chromium.org/2992693002/diff/20001/client/cmd/isolate/uploader.go > File client/cmd/isolate/uploader.go (right): > > https://codereview.chromium.org/2992693002/diff/20001/client/cmd/isolate/uploader.go#newcode39 > ...
3 years, 4 months ago (2017-07-31 04:57:22 UTC) #6
mcgreevy
On 2017/07/31 04:57:22, mithro wrote: > On 2017/07/31 04:42:12, mcgreevy wrote: > > > https://codereview.chromium.org/2992693002/diff/20001/client/cmd/isolate/uploader.go ...
3 years, 4 months ago (2017-07-31 05:08:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2992693002/40001
3 years, 4 months ago (2017-07-31 05:08:46 UTC) #10
commit-bot: I haz the power
3 years, 4 months ago (2017-07-31 05:15:21 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/7875602af13ed009f3e609f698fb7aba3b1787df

Powered by Google App Engine
This is Rietveld 408576698