isolate: add uploadtracker tests for symlinks and isolated files

isolate: add uploadtracker tests for symlinks and isolated files

BUG=692940
Review-Url: https://codereview.chromium.org/2992693002
Committed: https://github.com/luci/luci-go/commit/7875602af13ed009f3e609f698fb7aba3b1787df

[mcgreevy, 2017-07-28 06:38:41]

Description was changed from

==========
isolate: add uploadtracker_tests for symlinks and isolated files

BUG=692940
==========

to

==========
isolate: add uploadtracker tests for symlinks and isolated files

BUG=692940
==========

[mcgreevy, 2017-07-28 06:38:51]

mcgreevy@chromium.org changed reviewers:
+ tansell@chromium.org

[mithro, 2017-07-31 02:34:26]

LGTM. Having tests for this code is awesome!

Only question was why it was called a "CappedUploader"?

https://codereview.chromium.org/2992693002/diff/20001/client/cmd/isolate/uplo...
File client/cmd/isolate/uploader.go (right):

https://codereview.chromium.org/2992693002/diff/20001/client/cmd/isolate/uplo...
client/cmd/isolate/uploader.go:39: // CappedUploader uses an
isolatedclient.Client to upload items to the server.
I'm not sure I understand why this is called a "CappedUploader"?

[mcgreevy, 2017-07-31 04:42:12]

https://codereview.chromium.org/2992693002/diff/20001/client/cmd/isolate/uplo...
File client/cmd/isolate/uploader.go (right):

https://codereview.chromium.org/2992693002/diff/20001/client/cmd/isolate/uplo...
client/cmd/isolate/uploader.go:39: // CappedUploader uses an
isolatedclient.Client to upload items to the server.
On 2017/07/31 02:34:26, mithro wrote:
> I'm not sure I understand why this is called a "CappedUploader"?

I needed a name other than "Uploader", and I picked this because "Capped" does
describe on of its characteristics (it uses waitc to cap concurrent uploads).  I
supposed I could have chosen something generic like UploaderImpl, but that
sounds very C++-ey and in the end I decided that this name would not be very
visible anyway, so I decided to stop spending time on name-choosing.  Let me
know if you can think of something better.

[mithro, 2017-07-31 04:57:22]

On 2017/07/31 04:42:12, mcgreevy wrote:
>
https://codereview.chromium.org/2992693002/diff/20001/client/cmd/isolate/uplo...
> File client/cmd/isolate/uploader.go (right):
> 
>
https://codereview.chromium.org/2992693002/diff/20001/client/cmd/isolate/uplo...
> client/cmd/isolate/uploader.go:39: // CappedUploader uses an
> isolatedclient.Client to upload items to the server.
> On 2017/07/31 02:34:26, mithro wrote:
> > I'm not sure I understand why this is called a "CappedUploader"?
> 
> I needed a name other than "Uploader", and I picked this because "Capped" does
> describe on of its characteristics (it uses waitc to cap concurrent uploads). 
I
> supposed I could have chosen something generic like UploaderImpl, but that
> sounds very C++-ey and in the end I decided that this name would not be very
> visible anyway, so I decided to stop spending time on name-choosing.  Let me
> know if you can think of something better.

Maybe just ConcurrentUploader ?

[mcgreevy, 2017-07-31 05:08:36]

On 2017/07/31 04:57:22, mithro wrote:
> On 2017/07/31 04:42:12, mcgreevy wrote:
> >
>
https://codereview.chromium.org/2992693002/diff/20001/client/cmd/isolate/uplo...
> > File client/cmd/isolate/uploader.go (right):
> > 
> >
>
https://codereview.chromium.org/2992693002/diff/20001/client/cmd/isolate/uplo...
> > client/cmd/isolate/uploader.go:39: // CappedUploader uses an
> > isolatedclient.Client to upload items to the server.
> > On 2017/07/31 02:34:26, mithro wrote:
> > > I'm not sure I understand why this is called a "CappedUploader"?
> > 
> > I needed a name other than "Uploader", and I picked this because "Capped"
does
> > describe on of its characteristics (it uses waitc to cap concurrent
uploads). 
> I
> > supposed I could have chosen something generic like UploaderImpl, but that
> > sounds very C++-ey and in the end I decided that this name would not be very
> > visible anyway, so I decided to stop spending time on name-choosing.  Let me
> > know if you can think of something better.
> 
> Maybe just ConcurrentUploader ?

Done.

[mcgreevy, 2017-07-31 05:08:39]

The CQ bit was checked by mcgreevy@chromium.org

[mcgreevy, 2017-07-31 05:08:40]

The patchset sent to the CQ was uploaded after l-g-t-m from tansell@chromium.org
Link to the patchset: https://codereview.chromium.org/2992693002/#ps40001
(title: "address review comments")

[commit-bot: I haz the power, 2017-07-31 05:08:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-31 05:15:17]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1501477719662900,
"parent_rev": "8fbab6da1f9e6c96cdcea4159a3b8e11f9ccace2", "commit_rev":
"7875602af13ed009f3e609f698fb7aba3b1787df"}

[commit-bot: I haz the power, 2017-07-31 05:15:20]

Description was changed from

==========
isolate: add uploadtracker tests for symlinks and isolated files

BUG=692940
==========

to

==========
isolate: add uploadtracker tests for symlinks and isolated files

BUG=692940

Review-Url: https://codereview.chromium.org/2992693002
Committed:
https://github.com/luci/luci-go/commit/7875602af13ed009f3e609f698fb7aba3b1787df
==========

[commit-bot: I haz the power, 2017-07-31 05:15:21]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/7875602af13ed009f3e609f698fb7aba3b1787df