Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issue 2992623002: Re-land of CL 2990703002, adding fixes to analyzer_test and error_test. (Closed)

Created:
3 years, 4 months ago by eernst
Modified:
3 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, floitsch
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Re-land of CL 2990703002, adding fixes to analyzer_test and error_test. This CL is identical to the reverted CL 2990703002 which implements syntactic support for generalized void in the analyzer, plus two bug fixes in pkg/analyzer/test/generated/parser_test.dart and pkg/analyzer_cli/test/error_test.dart. In the former, a test on parsing `void,` was changed to expect an error: _isTypeIdentifier on a lone `void` will no longer return true, which is necessary because `void` can now be used as a type annotation alone. Another test on `void x` was added, which produces the behavior previously seen for `void,`. In error_test, the error which is used throughout was changed from `void foo;` to `var int foo;` (because the former is no longer an error). Committed: https://github.com/dart-lang/sdk/commit/9336e199fd7360ee229de5b4ebef5940aab266ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -196 lines) Patch
M pkg/analyzer/lib/error/error.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/dart/error/syntactic_errors.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M pkg/analyzer/lib/src/error/codes.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 2 chunks +0 lines, -14 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 29 chunks +81 lines, -94 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 6 chunks +29 lines, -15 lines 0 comments Download
M pkg/analyzer/test/generated/static_warning_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_cli/test/error_test.dart View 2 chunks +13 lines, -23 lines 0 comments Download
M tests/co19/co19-analyzer2.status View 2 chunks +5 lines, -0 lines 0 comments Download
M tests/language/generalized_void_syntax_test.dart View 3 chunks +17 lines, -14 lines 0 comments Download
M tests/language/language.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language_dart2js.status View 2 chunks +2 lines, -0 lines 0 comments Download
M tests/language/syntax_test.dart View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
eernst
TBR, only adjusts two tests compared to the CL landed yesterday.
3 years, 4 months ago (2017-07-27 10:37:00 UTC) #2
eernst
3 years, 4 months ago (2017-07-27 10:39:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9336e199fd7360ee229de5b4ebef5940aab266ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698