|
Re-land of CL 2990703002, adding fixes to analyzer_test and error_test.
This CL is identical to the reverted CL 2990703002 which implements
syntactic support for generalized void in the analyzer, plus two bug
fixes in pkg/analyzer/test/generated/parser_test.dart and
pkg/analyzer_cli/test/error_test.dart. In the former, a test on parsing
`void,` was changed to expect an error: _isTypeIdentifier on a lone
`void` will no longer return true, which is necessary because `void`
can now be used as a type annotation alone. Another test on `void x`
was added, which produces the behavior previously seen for `void,`.
In error_test, the error which is used throughout was changed from
`void foo;` to `var int foo;` (because the former is no longer an
error).
Committed: https://github.com/dart-lang/sdk/commit/9336e199fd7360ee229de5b4ebef5940aab266ec
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+159 lines, -196 lines) |
Patch |
|
M |
pkg/analyzer/lib/error/error.dart
|
View
|
|
2 chunks |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
pkg/analyzer/lib/src/dart/error/syntactic_errors.dart
|
View
|
|
1 chunk |
+0 lines, -12 lines |
0 comments
|
Download
|
|
M |
pkg/analyzer/lib/src/error/codes.dart
|
View
|
|
1 chunk |
+0 lines, -10 lines |
0 comments
|
Download
|
|
M |
pkg/analyzer/lib/src/generated/error_verifier.dart
|
View
|
|
2 chunks |
+0 lines, -14 lines |
0 comments
|
Download
|
|
M |
pkg/analyzer/lib/src/generated/parser.dart
|
View
|
|
29 chunks |
+81 lines, -94 lines |
0 comments
|
Download
|
|
M |
pkg/analyzer/test/generated/parser_test.dart
|
View
|
|
6 chunks |
+29 lines, -15 lines |
0 comments
|
Download
|
|
M |
pkg/analyzer/test/generated/static_warning_code_test.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
pkg/analyzer_cli/test/error_test.dart
|
View
|
|
2 chunks |
+13 lines, -23 lines |
0 comments
|
Download
|
|
M |
tests/co19/co19-analyzer2.status
|
View
|
|
2 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
tests/language/generalized_void_syntax_test.dart
|
View
|
|
3 chunks |
+17 lines, -14 lines |
0 comments
|
Download
|
|
M |
tests/language/language.status
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
tests/language/language_analyzer2.status
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
tests/language/language_dart2js.status
|
View
|
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
tests/language/syntax_test.dart
|
View
|
|
2 chunks |
+9 lines, -9 lines |
0 comments
|
Download
|
Total messages: 4 (2 generated)
|