Re-land of CL 2990703002, adding fixes to analyzer_test and error_test.

pkg/analyzer/lib/src/generated/error_verifier.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.generated.error_verifier;
 
 import 'dart:collection';
 import "dart:math" as math;
 
 import 'package:analyzer/dart/ast/ast.dart';
@@ skipping 944 matching lines @@
       SimpleIdentifier identifier = node.name;
       String methodName = "";
       if (identifier != null) {
         methodName = identifier.name;
       }
       TypeAnnotation returnType = node.returnType;
       if (node.isSetter || node.isGetter) {
         _checkForMismatchedAccessorTypes(node, methodName);
       }
       if (node.isGetter) {
-        _checkForVoidReturnType(node);
         _checkForConflictingStaticGetterAndInstanceSetter(node);
       } else if (node.isSetter) {
         _checkForInvalidModifierOnBody(
             node.body, CompileTimeErrorCode.INVALID_MODIFIER_ON_SETTER);
         _checkForWrongNumberOfParametersForSetter(node.name, node.parameters);
         _checkForNonVoidReturnTypeForSetter(returnType);
         _checkForConflictingStaticSetterAndInstanceMember(node);
       } else if (node.isOperator) {
         _checkForOptionalParameterInOperator(node);
         _checkForWrongNumberOfParametersForOperator(node);
@@ skipping 5058 matching lines @@
         }
       }
     }
 //        else {
 //        // TODO(jwren) Report error, constructor initializer variable is a top level element
 //        // (Either here or in ErrorVerifier.checkForAllFinalInitializedErrorCodes)
 //        }
   }
 
   /**
-   * Verify that the given [getter] does not have a return type of 'void'.
-   *
-   * See [StaticWarningCode.VOID_RETURN_FOR_GETTER].
-   */
-  void _checkForVoidReturnType(MethodDeclaration getter) {
-    TypeAnnotation returnType = getter.returnType;
-    if (returnType is TypeName && returnType.name.name == "void") {
-      _errorReporter.reportErrorForNode(
-          StaticWarningCode.VOID_RETURN_FOR_GETTER, returnType);
-    }
-  }
-
-  /**
    * Verify the given operator-method [declaration], has correct number of
    * parameters.
    *
    * This method assumes that the method declaration was tested to be an
    * operator declaration before being called.
    *
    * See [CompileTimeErrorCode.WRONG_NUMBER_OF_PARAMETERS_FOR_OPERATOR].
    */
   void _checkForWrongNumberOfParametersForOperator(
       MethodDeclaration declaration) {
@@ skipping 1091 matching lines @@
 class _InvocationCollector extends RecursiveAstVisitor {
   final List<String> superCalls = <String>[];
 
   @override
   visitMethodInvocation(MethodInvocation node) {
     if (node.target is SuperExpression) {
       superCalls.add(node.methodName.name);
     }
   }
 }