Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 2992493002: Fix the problem with the TryChromeAgain toast appearing in the wrong place on scale factors other t… (Closed)

Created:
3 years, 4 months ago by ananta
Modified:
3 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the problem with the TryChromeAgain toast appearing in the wrong place on scale factors other than 1 Reason being we were converting a rectangle which was already in DIPS to DIPs. Fix is to return a smaller rectangle with the correct origin. Additionally the size passed to set the toast region has to be in pixels. BUG=731026 Reset to tip Review-Url: https://codereview.chromium.org/2992493002 Cr-Commit-Position: refs/heads/master@{#489707} Committed: https://chromium.googlesource.com/chromium/src/+/655c7008fb0dc647d743c706797d55e5cccd9f65

Patch Set 1 #

Patch Set 2 : Revert changes to fullscreen handler #

Patch Set 3 : The window region for the toast has to be in pixels #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/browser/ui/views/try_chrome_dialog_view.cc View 1 2 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
ananta
3 years, 4 months ago (2017-07-26 00:54:45 UTC) #2
ananta
On 2017/07/26 00:54:45, ananta wrote: Please hold off for a bit
3 years, 4 months ago (2017-07-26 01:02:21 UTC) #5
ananta
On 2017/07/26 01:02:21, ananta wrote: > On 2017/07/26 00:54:45, ananta wrote: > > Please hold ...
3 years, 4 months ago (2017-07-26 01:17:38 UTC) #7
sky
LGTM
3 years, 4 months ago (2017-07-26 15:35:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2992493002/40001
3 years, 4 months ago (2017-07-26 18:27:13 UTC) #14
commit-bot: I haz the power
3 years, 4 months ago (2017-07-26 18:35:21 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/655c7008fb0dc647d743c706797d...

Powered by Google App Engine
This is Rietveld 408576698