Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2992253002: [wpr-go] Use a dummy cert if no cert is recorded (Closed)

Created:
3 years, 4 months ago by xunjieli
Modified:
3 years, 4 months ago
Reviewers:
nednguyen, Tom Bergan
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[wpr-go] Use a dummy cert if no cert is recorded Sometimes, chrome can request a http url and gets redirected to a https url. During conversion of .wpr to .wprgo, we do not know whether this behavior will happen. This makes WprGo error out on certain sites (e.g. system_health_desktop's load:tools:weather). This CL is to make the cert-not-in-archive error not fatal. BUG=catapult:#3629 Review-Url: https://codereview.chromium.org/2992253002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/357e1deefca78c61e457f340270c9cd6f38321f5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -39 lines) Patch
M telemetry/telemetry/internal/binary_dependencies.json View 1 chunk +8 lines, -8 lines 0 comments Download
M web_page_replay_go/src/webpagereplay/certs.go View 7 chunks +34 lines, -4 lines 0 comments Download
M web_page_replay_go/src/webpagereplay/legacyformatconvertor.go View 3 chunks +1 line, -27 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
xunjieli
It turns out that load:tools:weather doesn't load the page at all. This fixes the error.
3 years, 4 months ago (2017-08-03 21:39:26 UTC) #2
xunjieli
Tom, could you review this? Ned seems to be out. There are a few stories ...
3 years, 4 months ago (2017-08-03 21:58:03 UTC) #6
nednguyen
lgtm
3 years, 4 months ago (2017-08-03 22:15:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2992253002/1
3 years, 4 months ago (2017-08-03 22:15:32 UTC) #11
commit-bot: I haz the power
3 years, 4 months ago (2017-08-03 22:16:38 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698