Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1263)

Issue 2991653002: Fix Actual CIPD versions (Closed)

Created:
3 years, 4 months ago by kjlubick
Modified:
3 years, 4 months ago
Reviewers:
KevinL, stephana
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, M-A Ruel
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Fix Actual CIPD versions Prior, this code was confusing "path" with "package_name" - the latter is unique, the former is not. BUG=748167 Review-Url: https://codereview.chromium.org/2991653002 Committed: https://github.com/luci/luci-py/commit/96051a6f3c07ec928b3a6bb292f27219dedac0bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M appengine/swarming/ui/build/elements.html View 1 chunk +7 lines, -6 lines 0 comments Download
M appengine/swarming/ui/res/imp/taskpage/task-page.html View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
kjlubick
3 years, 4 months ago (2017-07-25 13:15:06 UTC) #2
KevinL
lgtm
3 years, 4 months ago (2017-07-25 13:16:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2991653002/1
3 years, 4 months ago (2017-07-25 13:16:12 UTC) #7
commit-bot: I haz the power
3 years, 4 months ago (2017-07-25 13:20:27 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/96051a6f3c07ec928b3a6bb292f27219dedac0bf

Powered by Google App Engine
This is Rietveld 408576698