Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 2991423002: Use journald for logging with systemd (Closed)

Created:
3 years, 4 months ago by Petr Hosek
Modified:
3 years, 4 months ago
Reviewers:
Vadim Sh., smut, phosek
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Use journald for logging with systemd /var/log/messages is an existing file on Debian and hence unusable to store logs. Rather than trying to figure out a path that would work across all different distributions, use journald for logging on systemd based systems. Review-Url: https://codereview.chromium.org/2991423002 Committed: https://github.com/luci/luci-py/commit/55e6a2a93ab96fb928638aca733ae399eec4d8e0

Patch Set 1 #

Patch Set 2 : Fallback mechanism #

Patch Set 3 : Update class name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M appengine/gce-backend/agent/agent.py View 1 2 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
phosek
3 years, 4 months ago (2017-08-04 06:38:43 UTC) #4
smut
lgtm
3 years, 4 months ago (2017-08-04 23:20:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2991423002/40001
3 years, 4 months ago (2017-08-04 23:55:48 UTC) #8
commit-bot: I haz the power
3 years, 4 months ago (2017-08-04 23:58:03 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-py/commit/55e6a2a93ab96fb928638aca733ae399eec4d8e0

Powered by Google App Engine
This is Rietveld 408576698