Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2991383002: Milo: Actually shorten step text (Closed)

Created:
3 years, 4 months ago by Ryan Tseng
Modified:
3 years, 4 months ago
Reviewers:
dnj, iannucci
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M milo/api/resp/build.go View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Ryan Tseng
ptal small change, i derped and didn't notice text was []string
3 years, 4 months ago (2017-08-03 18:48:54 UTC) #4
dnj
Oh Text is an array lol~ lgtm
3 years, 4 months ago (2017-08-03 18:57:48 UTC) #7
Ryan Tseng
Yeah it's an artifact from buildbot, it didn't seem like a bad idea at the ...
3 years, 4 months ago (2017-08-03 18:59:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2991383002/1
3 years, 4 months ago (2017-08-03 18:59:23 UTC) #10
commit-bot: I haz the power
3 years, 4 months ago (2017-08-03 19:03:08 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/a2c4aedab81206b6d01b85dae474f93ce9ed804c

Powered by Google App Engine
This is Rietveld 408576698