Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2991303002: Add in OAuth authentication to Isolate Polymer UI (Closed)

Created:
3 years, 4 months ago by kjlubick
Modified:
3 years, 4 months ago
Reviewers:
stephana, M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Add in OAuth authentication to Isolate Polymer UI This adds a new folder for shared elements and maps it into the isolate/ui and swarming/ui folder BUG=749241 Review-Url: https://codereview.chromium.org/2991303002 Committed: https://github.com/luci/luci-py/commit/c8850625a8c2bdd2585033643dd7345c9e42e2d5

Patch Set 1 #

Patch Set 2 : Rebuild #

Patch Set 3 : Fix typos #

Patch Set 4 : Fix GET request for server_details #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -643 lines) Patch
M appengine/isolate/handlers_endpoints_v1.py View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M appengine/isolate/ui/build/elements.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A appengine/isolate/ui/res/imp/common/common-behavior.html View 1 2 3 1 chunk +140 lines, -0 lines 0 comments Download
A + appengine/isolate/ui/res/imp/common/isolate-app.html View 1 2 3 9 chunks +14 lines, -30 lines 0 comments Download
M appengine/isolate/ui/res/imp/index/isolate-index.html View 2 3 1 chunk +11 lines, -7 lines 0 comments Download
M appengine/isolate/ui/res/imp/index/isolate-index-demo.html View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
A appengine/isolate/ui/res/imp/shared View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M appengine/swarming/ui/build/elements.html View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M appengine/swarming/ui/res/imp/botlist/bot-filters.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/ui/res/imp/botlist/bot-list.html View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M appengine/swarming/ui/res/imp/botpage/bot-page.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/ui/res/imp/botpage/bot-page-summary.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
D appengine/swarming/ui/res/imp/common/auth-signin.html View 1 2 3 1 chunk +0 lines, -169 lines 0 comments Download
D appengine/swarming/ui/res/imp/common/error-toast.html View 1 2 3 1 chunk +0 lines, -56 lines 0 comments Download
D appengine/swarming/ui/res/imp/common/interval-timer.html View 1 2 3 1 chunk +0 lines, -51 lines 0 comments Download
D appengine/swarming/ui/res/imp/common/sort-toggle.html View 1 2 3 1 chunk +0 lines, -127 lines 0 comments Download
M appengine/swarming/ui/res/imp/common/swarming-app.html View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
D appengine/swarming/ui/res/imp/common/url-param.html View 1 2 3 1 chunk +0 lines, -188 lines 0 comments Download
A appengine/swarming/ui/res/imp/shared View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M appengine/swarming/ui/res/imp/tasklist/task-filters.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/ui/res/imp/tasklist/task-list.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M appengine/swarming/ui/res/imp/taskpage/task-page.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A appengine/ui/README.md View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A + appengine/ui/auth-signin.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/ui/error-toast.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/ui/interval-timer.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/ui/sort-toggle.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/ui/url-param.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
kjlubick
See it live at https://3018-1edc7b3-tainted-kjlubick-dot-isolateserver-dev.appspot.com/newui If you see Server: 3018-1edc7b3-tainted-kjlubick in the upper right hand ...
3 years, 4 months ago (2017-08-03 14:52:39 UTC) #3
M-A Ruel
python lgtm, directory layout lgtm, the rest rs lgtm.
3 years, 4 months ago (2017-08-03 15:37:13 UTC) #4
kjlubick
3 years, 4 months ago (2017-08-03 16:40:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2991303002/40001
3 years, 4 months ago (2017-08-03 16:40:42 UTC) #7
commit-bot: I haz the power
3 years, 4 months ago (2017-08-03 16:44:41 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 (id:40001) as
https://github.com/luci/luci-py/commit/c8850625a8c2bdd2585033643dd7345c9e42e2d5

Powered by Google App Engine
This is Rietveld 408576698