Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2991193002: Clear LUCI_CONTEXT when running auth test. (Closed)

Created:
3 years, 4 months ago by Vadim Sh.
Modified:
3 years, 4 months ago
Reviewers:
dnj, tandrii(chromium)
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Clear LUCI_CONTEXT when running auth test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M common/auth/internal/luci_ctx_test.go View 1 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
Vadim Sh.
PTAL
3 years, 4 months ago (2017-08-01 21:50:31 UTC) #1
Vadim Sh.
On 2017/08/01 21:50:31, Vadim Sh. wrote: > PTAL Welp, it doesn't work. lucictx library loads ...
3 years, 4 months ago (2017-08-01 21:55:49 UTC) #4
Vadim Sh.
works now
3 years, 4 months ago (2017-08-01 22:06:45 UTC) #9
dnj
lgtm
3 years, 4 months ago (2017-08-01 22:08:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2991193002/20001
3 years, 4 months ago (2017-08-01 22:11:48 UTC) #13
tandrii(chromium)
lgtm, thank you!
3 years, 4 months ago (2017-08-01 22:22:22 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://github.com/luci/luci-go/commit/db21483023eebb29ad6bcf00585a6b854609c657
3 years, 4 months ago (2017-08-01 22:23:47 UTC) #17
tandrii(chromium)
3 years, 4 months ago (2017-08-01 22:25:30 UTC) #18
Message was sent while issue was closed.
presubmit bot seems unhappy, 8 min pcg run isn't right.

Powered by Google App Engine
This is Rietveld 408576698