Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2991153002: Add stub for new polymer-based Isolate UI (Closed)

Created:
3 years, 4 months ago by kjlubick
Modified:
3 years, 4 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, stephana-chromium
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Add stub for new polymer-based Isolate UI This just adds a hello world Polymer page and JS. The structure is identical to the Swarming UI. BUG=749241 Review-Url: https://codereview.chromium.org/2991153002 Committed: https://github.com/luci/luci-py/commit/1edc7b3b32c67c27b599035db39d8e7f3b79fcd8

Patch Set 1 #

Patch Set 2 : Add license #

Patch Set 3 : fix common.js #

Patch Set 4 : fix common.js #

Total comments: 10

Patch Set 5 : Address feedback #

Patch Set 6 : Address feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -0 lines) Patch
M appengine/isolate/app.yaml View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M appengine/isolate/handlers_frontend.py View 1 2 3 4 5 2 chunks +22 lines, -0 lines 0 comments Download
A appengine/isolate/templates/public_isolate_index.html View 1 1 chunk +27 lines, -0 lines 0 comments Download
A appengine/isolate/ui/.bowerrc View 1 1 chunk +3 lines, -0 lines 0 comments Download
A appengine/isolate/ui/.gitignore View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
A appengine/isolate/ui/Makefile View 1 1 chunk +52 lines, -0 lines 0 comments Download
A appengine/isolate/ui/README.md View 1 chunk +1 line, -0 lines 0 comments Download
A appengine/isolate/ui/bower.json View 1 1 chunk +23 lines, -0 lines 0 comments Download
A appengine/isolate/ui/build/elements.html View 1 1 chunk +4 lines, -0 lines 0 comments Download
A appengine/isolate/ui/build/js/js.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
A appengine/isolate/ui/elements.html View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download
A appengine/isolate/ui/package.json View 1 1 chunk +16 lines, -0 lines 0 comments Download
A appengine/isolate/ui/res/imp/index/isolate-index.html View 1 2 3 4 1 chunk +56 lines, -0 lines 0 comments Download
A appengine/isolate/ui/res/imp/index/isolate-index-demo.html View 1 1 chunk +38 lines, -0 lines 0 comments Download
A appengine/isolate/ui/res/js/common.js View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
kjlubick
3 years, 4 months ago (2017-08-01 18:58:10 UTC) #3
kjlubick
See it working at https://3011-6a73e17-tainted-kjlubick-dot-isolateserver-dev.appspot.com/newui
3 years, 4 months ago (2017-08-01 18:58:32 UTC) #4
M-A Ruel
lgtm https://codereview.chromium.org/2991153002/diff/60001/appengine/isolate/handlers_frontend.py File appengine/isolate/handlers_frontend.py (right): https://codereview.chromium.org/2991153002/diff/60001/appengine/isolate/handlers_frontend.py#newcode393 appengine/isolate/handlers_frontend.py:393: configuration.""" """ on its own line https://codereview.chromium.org/2991153002/diff/60001/appengine/isolate/ui/.gitignore File ...
3 years, 4 months ago (2017-08-01 19:13:14 UTC) #5
kjlubick
https://codereview.chromium.org/2991153002/diff/60001/appengine/isolate/handlers_frontend.py File appengine/isolate/handlers_frontend.py (right): https://codereview.chromium.org/2991153002/diff/60001/appengine/isolate/handlers_frontend.py#newcode393 appengine/isolate/handlers_frontend.py:393: configuration.""" On 2017/08/01 at 19:13:13, M-A Ruel wrote: > ...
3 years, 4 months ago (2017-08-02 12:51:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2991153002/80001
3 years, 4 months ago (2017-08-02 12:51:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2991153002/100001
3 years, 4 months ago (2017-08-02 12:52:30 UTC) #13
commit-bot: I haz the power
3 years, 4 months ago (2017-08-02 12:55:09 UTC) #16
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://github.com/luci/luci-py/commit/1edc7b3b32c67c27b599035db39d8e7f3b79fcd8

Powered by Google App Engine
This is Rietveld 408576698