Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2991053002: Vendor 'luci_context' library. (Closed)

Created:
3 years, 4 months ago by Vadim Sh.
Modified:
3 years, 4 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Vendor 'luci_context' library. To be used from some recipe module ('context'?) to modify LUCI_CONTEXT of the step (in particular, for switching Goma into using 'system' account). R=iannucci@chromium.org BUG=731854 Review-Url: https://codereview.chromium.org/2991053002 Committed: https://github.com/luci/recipes-py/commit/862f33385b0c24846ea7850b4c1bdf646cafcf60

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+398 lines, -1 line) Patch
M bootstrap/update_vendoring.py View 1 chunk +0 lines, -1 line 0 comments Download
A recipe_engine/third_party/client-py/libs/luci_context/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A recipe_engine/third_party/client-py/libs/luci_context/__init__.py View 1 chunk +6 lines, -0 lines 0 comments Download
A recipe_engine/third_party/client-py/libs/luci_context/luci_context.py View 1 chunk +264 lines, -0 lines 0 comments Download
A recipe_engine/third_party/client-py/libs/luci_context/luci_context_test.py View 1 chunk +126 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
Vadim Sh.
I tried to use update_vendoring.py. It had syntax error. I fixed it, ran it again. ...
3 years, 4 months ago (2017-07-28 23:27:21 UTC) #1
iannucci
lgtm lgtm, I'm going to be updating the logdog library shortly anyway
3 years, 4 months ago (2017-08-07 19:34:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2991053002/1
3 years, 4 months ago (2017-08-07 19:38:21 UTC) #4
commit-bot: I haz the power
3 years, 4 months ago (2017-08-07 19:44:42 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/862f33385b0c24846ea7850b4c1bdf646ca...

Powered by Google App Engine
This is Rietveld 408576698