Web Animations API: Avoid style resolution when calling element.animate()

Source/core/animation/EffectInput.cpp

Index: Source/core/animation/EffectInput.cpp
diff --git a/Source/core/animation/EffectInput.cpp b/Source/core/animation/EffectInput.cpp
index 869e3b47c0df959d265d63a0d9562a0455113b24..fef23d149ff6752fd18c1ddc3832dedb22701a6d 100644
--- a/Source/core/animation/EffectInput.cpp
+++ b/Source/core/animation/EffectInput.cpp
@@ -43,19 +43,16 @@
 namespace WebCore {
 
 // FIXME: Remove this once we've removed the dependency on Element.
-static bool checkDocumentAndRenderer(Element* element)
+static bool checkDocument(Element* element)
 {
-    if (!element || !element->inActiveDocument())
-        return false;
-    element->document().updateRenderTreeIfNeeded();
-    return element->renderer();

[alancutter (OOO until 2018), 2014/05/23 07:01:36]

I think we still need to check for renderer() in case animate() is called on a
display: none element.
We should write a test for this case in another patch.

[dstockwell, 2014/05/23 07:40:58]

But, we won't know whether or not there should be a renderer unless we call
updateRenderTreeIfNeeded...

[dstockwell, 2014/05/23 07:42:25]

Wait, why do we care if it's display: none?

[dstockwell, 2014/05/23 07:44:29]

Ahh, because of forceConversions... Hmm, I'm not sure this patch can work.

+    return (element && element->inActiveDocument());
 }
 
 PassRefPtrWillBeRawPtr<AnimationEffect> EffectInput::convert(Element* element, const Vector<Dictionary>& keyframeDictionaryVector, ExceptionState& exceptionState, bool unsafe)
 {
     // FIXME: This test will not be neccessary once resolution of keyframe values occurs at
     // animation application time.
-    if (!unsafe && !checkDocumentAndRenderer(element))
+    if (!unsafe && !checkDocument(element))
         return nullptr;
 
     StyleSheetContents* styleSheetContents = element->document().elementSheet().contents();