Web Animations API: Avoid style resolution when calling element.animate()

Source/core/animation/EffectInput.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 25 matching lines @@
 #include "core/animation/KeyframeEffectModel.h"
 #include "core/animation/StringKeyframe.h"
 #include "core/css/parser/BisonCSSParser.h"
 #include "core/css/resolver/StyleResolver.h"
 #include "core/dom/Element.h"
 #include "wtf/NonCopyingSort.h"
 
 namespace WebCore {
 
 // FIXME: Remove this once we've removed the dependency on Element.
-static bool checkDocumentAndRenderer(Element* element)
+static bool checkDocument(Element* element)
 {
-    if (!element || !element->inActiveDocument())
-        return false;
-    element->document().updateRenderTreeIfNeeded();
-    return element->renderer();

[alancutter (OOO until 2018), 2014/05/23 07:01:36]

I think we still need to check for renderer() in case animate() is called on a
display: none element.
We should write a test for this case in another patch.

[dstockwell, 2014/05/23 07:40:58]

But, we won't know whether or not there should be a renderer unless we call
updateRenderTreeIfNeeded...

[dstockwell, 2014/05/23 07:42:25]

Wait, why do we care if it's display: none?

[dstockwell, 2014/05/23 07:44:29]

Ahh, because of forceConversions... Hmm, I'm not sure this patch can work.

+    return (element && element->inActiveDocument());
 }
 
 PassRefPtrWillBeRawPtr<AnimationEffect> EffectInput::convert(Element* element, const Vector<Dictionary>& keyframeDictionaryVector, ExceptionState& exceptionState, bool unsafe)
 {
     // FIXME: This test will not be neccessary once resolution of keyframe values occurs at
     // animation application time.
-    if (!unsafe && !checkDocumentAndRenderer(element))
+    if (!unsafe && !checkDocument(element))
         return nullptr;
 
     StyleSheetContents* styleSheetContents = element->document().elementSheet().contents();
     StringKeyframeVector keyframes;
     bool everyFrameHasOffset = true;
     bool looselySortedByOffset = true;
     double lastOffset = -std::numeric_limits<double>::infinity();
 
     for (size_t i = 0; i < keyframeDictionaryVector.size(); ++i) {
         RefPtrWillBeRawPtr<StringKeyframe> keyframe = StringKeyframe::create();
@@ skipping 60 matching lines @@
     if (!keyframeEffectModel->isReplaceOnly()) {
         exceptionState.throwDOMException(NotSupportedError, "Partial keyframes are not supported.");
         return nullptr;
     }
     keyframeEffectModel->forceConversionsToAnimatableValues(element);
 
     return keyframeEffectModel;
 }
 
 } // namespace WebCore