Migrate test block 9 to Dart 2.0

Migrate test block 9 to Dart 2.0

Deleted http_resource_test – the associated classes no longer exist
Deleted int_fromEnvironment3 - validated type semantics
Tweaked hash_set_type_check – made it very simple.

Also tweaked some analyzer hints

R=rnystrom@google.com

Committed: https://github.com/dart-lang/sdk/commit/c347b0ed160ccdccdbfd7a9b23ea166e127c9a12

[kevmoo, 2017-07-25 19:19:10]

kevmoo@google.com changed reviewers:
+ jcollins@google.com, rnystrom@google.com

[jcollins, 2017-07-25 19:20:57]

On 2017/07/25 19:19:11, kevmoo wrote:

fyi, this is test block 9

[kevmoo, 2017-07-25 19:24:26]

Description was changed from

==========
Migrate test block 7 to Dart 2.0

Deleted http_resource_test – the associated classes no longer exist
Deleted int_fromEnvironment3 - validated type semantics
Tweaked hash_set_type_check – made it very simple.

Also tweaked some analyzer hints
==========

to

==========
Migrate test block 9 to Dart 2.0

Deleted http_resource_test – the associated classes no longer exist
Deleted int_fromEnvironment3 - validated type semantics
Tweaked hash_set_type_check – made it very simple.

Also tweaked some analyzer hints
==========

[Bob Nystrom, 2017-07-25 22:43:47]

One thing then LGTM!

https://codereview.chromium.org/2990623002/diff/1/tests/corelib_2/indexed_lis...
File tests/corelib_2/indexed_list_access_test.dart (right):

https://codereview.chromium.org/2990623002/diff/1/tests/corelib_2/indexed_lis...
tests/corelib_2/indexed_list_access_test.dart:8: // is not int.
I think we can delete this test entirely.

In Dart 2.0, it's a static error to pass a non-int to List.[], but there's
nothing special about List regarding that. It's just the general behavior of the
type system.

[kevmoo, 2017-07-25 23:43:14]

Description was changed from

==========
Migrate test block 9 to Dart 2.0

Deleted http_resource_test – the associated classes no longer exist
Deleted int_fromEnvironment3 - validated type semantics
Tweaked hash_set_type_check – made it very simple.

Also tweaked some analyzer hints
==========

to

==========
Migrate test block 9 to Dart 2.0

Deleted http_resource_test – the associated classes no longer exist
Deleted int_fromEnvironment3 - validated type semantics
Tweaked hash_set_type_check – made it very simple.

Also tweaked some analyzer hints

R=rnystrom@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c347b0ed160ccdccdbfd7a9b23ea166e127c9a12
==========

[kevmoo, 2017-07-25 23:43:15]

Committed patchset #2 (id:20001) manually as
c347b0ed160ccdccdbfd7a9b23ea166e127c9a12 (presubmit successful).