Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2990383002: Emit a hint when using generic method comment syntax (issue 30356) (Closed)

Created:
3 years, 4 months ago by Brian Wilkerson
Modified:
3 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-uxr+reviews_google.com, Jennifer Messerly
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Emit a hint when using generic method comment syntax (issue 30356) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/471b7fd568a50db10deba58054e2ee3852c43ff9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+529 lines, -798 lines) Patch
M pkg/analyzer/lib/error/error.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/error/hint_codes.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 6 chunks +58 lines, -57 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 3 chunks +17 lines, -40 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 48 chunks +272 lines, -71 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 4 chunks +10 lines, -10 lines 0 comments Download
M pkg/analyzer/test/generated/strong_mode_test.dart View 25 chunks +112 lines, -115 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 25 chunks +46 lines, -46 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 32 chunks +4 lines, -459 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 4 months ago (2017-08-08 14:44:06 UTC) #2
scheglov
LGTM
3 years, 4 months ago (2017-08-08 15:48:36 UTC) #3
Brian Wilkerson
3 years, 4 months ago (2017-08-08 16:12:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
471b7fd568a50db10deba58054e2ee3852c43ff9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698