Emit a hint when using generic method comment syntax (issue 30356)

pkg/analyzer/test/src/task/strong/checker_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.test.src.task.strong.checker_test;
 
 import 'package:test_reflective_loader/test_reflective_loader.dart';
 
 import 'strong_test_helper.dart';
 
@@ skipping 1116 matching lines @@
 typedef dynamic ATop(A x);
 typedef A BotA(dynamic x);
 typedef A AA(A x);
 typedef A TopA(Object x);
 typedef dynamic TopTop(Object x);
 
 dynamic aTop(A x) => x;
 A aa(A x) => x;
 dynamic topTop(dynamic x) => x;
 A topA(dynamic x) => /*info:DYNAMIC_CAST*/x;
-void apply/*<T>*/(/*=T*/ f0, /*=T*/ f1, /*=T*/ f2,
-                  /*=T*/ f3, /*=T*/ f4, /*=T*/ f5) {}
+void apply<T>(T f0, T f1, T f2,
+                  T f3, T f4, T f5) {}
 void main() {
   BotTop botTop;
   BotA botA;
   {
     BotTop f;
     f = topA;
     f = topTop;
     f = aa;
     f = aTop;
     f = botA;
     f = botTop;
-    apply/*<BotTop>*/(
+    apply<BotTop>(
         topA,
         topTop,
         aa,
         aTop,
         botA,
         botTop
                       );
-    apply/*<BotTop>*/(
+    apply<BotTop>(
         (dynamic x) => new A(),
         (dynamic x) => (x as Object),
         (A x) => x,
         (A x) => null,
         botA,
         botTop
                       );
   }
   {
     ATop f;
     f = topA;
     f = topTop;
     f = aa;
     f = aTop;
     f = /*error:INVALID_ASSIGNMENT*/botA;
     f = /*info:DOWN_CAST_COMPOSITE*/botTop;
-    apply/*<ATop>*/(
+    apply<ATop>(
         topA,
         topTop,
         aa,
         aTop,
         /*error:ARGUMENT_TYPE_NOT_ASSIGNABLE*/botA,
         /*info:DOWN_CAST_COMPOSITE*/botTop
                     );
-    apply/*<ATop>*/(
+    apply<ATop>(
         (dynamic x) => new A(),
         (dynamic x) => (x as Object),
         (A x) => x,
         (A x) => null,
         /*error:ARGUMENT_TYPE_NOT_ASSIGNABLE*/botA,
         /*info:DOWN_CAST_COMPOSITE*/botTop
                     );
   }
   {
     BotA f;
     f = topA;
     f = /*error:INVALID_ASSIGNMENT*/topTop;
     f = aa;
     f = /*error:INVALID_ASSIGNMENT*/aTop;
     f = botA;
     f = /*info:DOWN_CAST_COMPOSITE*/botTop;
-    apply/*<BotA>*/(
+    apply<BotA>(
         topA,
         /*error:ARGUMENT_TYPE_NOT_ASSIGNABLE*/topTop,
         aa,
         /*error:ARGUMENT_TYPE_NOT_ASSIGNABLE*/aTop,
         botA,
         /*info:DOWN_CAST_COMPOSITE*/botTop
                     );
-    apply/*<BotA>*/(
+    apply<BotA>(
         (dynamic x) => new A(),
         /*error:ARGUMENT_TYPE_NOT_ASSIGNABLE*/(dynamic x) => (x as Object),
         (A x) => x,
         /*error:ARGUMENT_TYPE_NOT_ASSIGNABLE*/(A x) => (/*info:UNNECESSARY_CAST*/x as Object),
         botA,
         /*info:DOWN_CAST_COMPOSITE*/botTop
                     );
   }
   {
     AA f;
     f = topA;
     f = /*error:INVALID_ASSIGNMENT*/topTop;
     f = aa;
     f = /*error:INVALID_CAST_FUNCTION*/aTop; // known function
     f = /*info:DOWN_CAST_COMPOSITE*/botA;
     f = /*info:DOWN_CAST_COMPOSITE*/botTop;
-    apply/*<AA>*/(
+    apply<AA>(
         topA,
         /*error:ARGUMENT_TYPE_NOT_ASSIGNABLE*/topTop,
         aa,
         /*error:INVALID_CAST_FUNCTION*/aTop, // known function
         /*info:DOWN_CAST_COMPOSITE*/botA,
         /*info:DOWN_CAST_COMPOSITE*/botTop
                   );
-    apply/*<AA>*/(
+    apply<AA>(
         (dynamic x) => new A(),
         /*error:ARGUMENT_TYPE_NOT_ASSIGNABLE*/(dynamic x) => (x as Object),
         (A x) => x,
         /*error:INVALID_CAST_FUNCTION_EXPR*/(A x) => (/*info:UNNECESSARY_CAST*/x as Object), // known function
         /*info:DOWN_CAST_COMPOSITE*/botA,
         /*info:DOWN_CAST_COMPOSITE*/botTop
                   );
   }
   {
     TopTop f;
     f = topA;
     f = topTop;
     f = /*error:INVALID_ASSIGNMENT*/aa;
     f = /*error:INVALID_CAST_FUNCTION*/aTop; // known function
     f = /*error:INVALID_ASSIGNMENT*/botA;
     f = /*info:DOWN_CAST_COMPOSITE*/botTop;
-    apply/*<TopTop>*/(
+    apply<TopTop>(
         topA,
         topTop,
         /*error:ARGUMENT_TYPE_NOT_ASSIGNABLE*/aa,
         /*error:INVALID_CAST_FUNCTION*/aTop, // known function
         /*error:ARGUMENT_TYPE_NOT_ASSIGNABLE*/botA,
         /*info:DOWN_CAST_COMPOSITE*/botTop
                       );
-    apply/*<TopTop>*/(
+    apply<TopTop>(
         (dynamic x) => new A(),
         (dynamic x) => (x as Object),
         /*error:ARGUMENT_TYPE_NOT_ASSIGNABLE*/(A x) => x,
         /*error:INVALID_CAST_FUNCTION_EXPR*/(A x) => (/*info:UNNECESSARY_CAST*/x as Object), // known function
         /*error:ARGUMENT_TYPE_NOT_ASSIGNABLE*/botA,
         /*info:DOWN_CAST_COMPOSITE*/botTop
                       );
   }
   {
     TopA f;
     f = topA;
     f = /*error:INVALID_CAST_FUNCTION*/topTop; // known function
     f = /*error:INVALID_CAST_FUNCTION*/aa; // known function
     f = /*error:INVALID_CAST_FUNCTION*/aTop; // known function
     f = /*info:DOWN_CAST_COMPOSITE*/botA;
     f = /*info:DOWN_CAST_COMPOSITE*/botTop;
-    apply/*<TopA>*/(
+    apply<TopA>(
         topA,
         /*error:INVALID_CAST_FUNCTION*/topTop, // known function
         /*error:INVALID_CAST_FUNCTION*/aa, // known function
         /*error:INVALID_CAST_FUNCTION*/aTop, // known function
         /*info:DOWN_CAST_COMPOSITE*/botA,
         /*info:DOWN_CAST_COMPOSITE*/botTop
                     );
-    apply/*<TopA>*/(
+    apply<TopA>(
         (dynamic x) => new A(),
         /*error:INVALID_CAST_FUNCTION_EXPR*/(dynamic x) => (x as Object), // known function
         /*error:INVALID_CAST_FUNCTION_EXPR*/(A x) => x, // known function
         /*error:INVALID_CAST_FUNCTION_EXPR*/(A x) => (/*info:UNNECESSARY_CAST*/x as Object), // known function
         /*info:DOWN_CAST_COMPOSITE*/botA,
         /*info:DOWN_CAST_COMPOSITE*/botTop
                     );
   }
 }
 ''');
@@ skipping 54 matching lines @@
   new A(new Callable());
 }
 
 void test1() {
   void takesF(f(int x)) => null;
   takesF((dynamic y) => 3);
 }
 
 void test2() {
   int x;
-  int f/*<T>*/(/*=T*/ t, callback(/*=T*/ x)) { return 3; }
+  int f<T>(T t, callback(T x)) { return 3; }
   f(x, (y) => 3);
 }
 ''');
   }
 
   test_functionTypingAndSubtyping_functionLiteralVariance() async {
     await checkFile('''
 class A {}
 class B extends A {}
 
@@ skipping 593 matching lines @@
   }
 }
 ''');
   }
 
   test_functionTypingAndSubtyping_subtypeOfUniversalType() async {
     await checkFile('''
 void main() {
   nonGenericFn(x) => null;
   {
-    /*=R*/ f/*<P, R>*/(/*=P*/ p) => null;
-    /*=T*/ g/*<S, T>*/(/*=S*/ s) => null;
+    R f<P, R>(P p) => null;
+    T g<S, T>(S s) => null;
 
     var local = f;
     local = g; // valid
 
     // Non-generic function cannot subtype a generic one.
     local = /*error:INVALID_ASSIGNMENT*/(x) => null;
     local = /*error:INVALID_ASSIGNMENT*/nonGenericFn;
   }
   {
-    Iterable/*<R>*/ f/*<P, R>*/(List/*<P>*/ p) => null;
-    List/*<T>*/ g/*<S, T>*/(Iterable/*<S>*/ s) => null;
+    Iterable<R> f<P, R>(List<P> p) => null;
+    List<T> g<S, T>(Iterable<S> s) => null;
 
     var local = f;
     local = g; // valid
 
     var local2 = g;
     local = local2;
     local2 = /*error:INVALID_CAST_FUNCTION*/f;
     local2 = /*info:DOWN_CAST_COMPOSITE*/local;
 
     // Non-generic function cannot subtype a generic one.
@@ skipping 37 matching lines @@
 }
 
 class Derived2<S extends B> extends Base<B> {
   S foo() => null;
 }
 ''');
   }
 
   test_genericFunctionWrongNumberOfArguments() async {
     await checkFile(r'''
-/*=T*/ foo/*<T>*/(/*=T*/ x, /*=T*/ y) => x;
-/*=T*/ bar/*<T>*/({/*=T*/ x, /*=T*/ y}) => x;
+T foo<T>(T x, T y) => x;
+T bar<T>({T x, T y}) => x;
 
 main() {
   String x;
   // resolving these shouldn't crash.
   foo/*error:EXTRA_POSITIONAL_ARGUMENTS*/(1, 2, 3);
   x = foo/*error:EXTRA_POSITIONAL_ARGUMENTS*/('1', '2', '3');
   foo/*error:NOT_ENOUGH_REQUIRED_ARGUMENTS*/(1);
   x = foo/*error:NOT_ENOUGH_REQUIRED_ARGUMENTS*/('1');
   x = foo/*error:EXTRA_POSITIONAL_ARGUMENTS*/(/*error:ARGUMENT_TYPE_NOT_ASSIGNABLE*/1, /*error:ARGUMENT_TYPE_NOT_ASSIGNABLE*/2, 3);
   x = foo/*error:NOT_ENOUGH_REQUIRED_ARGUMENTS*/(/*error:ARGUMENT_TYPE_NOT_ASSIGNABLE*/1);
 
   // named arguments
   bar(y: 1, x: 2, /*error:UNDEFINED_NAMED_PARAMETER*/z: 3);
   x = bar(/*error:UNDEFINED_NAMED_PARAMETER*/z: '1', x: '2', y: '3');
   bar(y: 1);
   x = bar(x: '1', /*error:UNDEFINED_NAMED_PARAMETER*/z: 42);
   x = bar(/*error:ARGUMENT_TYPE_NOT_ASSIGNABLE*/y: 1, /*error:ARGUMENT_TYPE_NOT_ASSIGNABLE*/x: 2, /*error:UNDEFINED_NAMED_PARAMETER*/z: 3);
   x = bar(/*error:ARGUMENT_TYPE_NOT_ASSIGNABLE*/x: 1);
 }
 ''');
   }
 
   test_genericMethodOverride() async {
     await checkFile('''
 class Future<T> {
-  /*=S*/ then/*<S>*/(/*=S*/ onValue(T t)) => null;
+  S then<S>(S onValue(T t)) => null;
 }
 
 class DerivedFuture<T> extends Future<T> {
-  /*=S*/ then/*<S>*/(/*=S*/ onValue(T t)) => null;
+  S then<S>(S onValue(T t)) => null;
 }
 
 class DerivedFuture2<A> extends Future<A> {
-  /*=B*/ then/*<B>*/(/*=B*/ onValue(A a)) => null;
+  B then<B>(B onValue(A a)) => null;
 }
 
 class DerivedFuture3<T> extends Future<T> {
-  /*=S*/ then/*<S>*/(Object onValue(T t)) => null;
+  S then<S>(Object onValue(T t)) => null;
 }
 
 class DerivedFuture4<A> extends Future<A> {
-  /*=B*/ then/*<B>*/(Object onValue(A a)) => null;
+  B then<B>(Object onValue(A a)) => null;
 }
 ''');
   }
 
   test_genericMethodSuper() async {
     await checkFile(r'''
 class A<T> {
   A<S> create<S extends T>() => new A<S>();
 }
 class B extends A {
@@ skipping 274 matching lines @@
       /*error:IMPLICIT_DYNAMIC_FIELD*/x4;
   dynamic y0;
   dynamic y1 = (<dynamic>[])[0];
 }
     ''');
     await check(implicitDynamic: false);
   }
 
   test_implicitDynamic_function() async {
     addFile(r'''
-/*=T*/ a/*<T>*/(/*=T*/ t) => t;
-/*=T*/ b/*<T>*/() => null;
+T a<T>(T t) => t;
+T b<T>() => null;
 
-void main/*<S>*/() {
+void main<S>() {
   dynamic d;
   int i;
   /*error:IMPLICIT_DYNAMIC_FUNCTION*/a(d);
   a(42);
   /*error:IMPLICIT_DYNAMIC_FUNCTION*/b();
   d = /*error:IMPLICIT_DYNAMIC_FUNCTION*/b();
   i = b();
 
-  void f/*<T>*/(/*=T*/ t) {};
-  /*=T*/ g/*<T>*/() => null;
+  void f<T>(T t) {};
+  T g<T>() => null;
 
   /*error:IMPLICIT_DYNAMIC_FUNCTION*/f(d);
   f(42);
   /*error:IMPLICIT_DYNAMIC_FUNCTION*/g();
   d = /*error:IMPLICIT_DYNAMIC_FUNCTION*/g();
   i = g();
 
-  /*error:IMPLICIT_DYNAMIC_INVOKE*/(/*<T>*/(/*=T*/ t) => t)(d);
-  (/*<T>*/(/*=T*/ t) => t)(42);
-  (/*<T>*/() => /*info:UNNECESSARY_CAST*/null as dynamic/*=T*/)/*<int>*/();
+  /*error:IMPLICIT_DYNAMIC_INVOKE*/(<T>(T t) => t)(d);
+  (<T>(T t) => t)(42);
+  (<T>() => /*info:UNNECESSARY_CAST*/null as T)<int>();
 }
     ''');
     await check(implicitDynamic: false);
   }
 
   test_implicitDynamic_listLiteral() async {
     addFile(r'''
 
 var l0 = /*error:IMPLICIT_DYNAMIC_LIST_LITERAL*/[];
 List l1 = /*error:IMPLICIT_DYNAMIC_LIST_LITERAL*/[];
@@ skipping 23 matching lines @@
 var m7 = <String, String>{};
 Map<String, String> m8 = /*info:INFERRED_TYPE_LITERAL*/{};
 var m9 = /*info:INFERRED_TYPE_LITERAL*/{'hi': 'there'};
     ''');
     await check(implicitDynamic: false);
   }
 
   test_implicitDynamic_method() async {
     addFile(r'''
 class C {
-  /*=T*/ m/*<T>*/(/*=T*/ s) => s;
-  /*=T*/ n/*<T>*/() => null;
+  T m<T>(T s) => s;
+  T n<T>() => null;
 }
 class D<E> {
-  /*=T*/ m/*<T>*/(/*=T*/ s) => s;
-  /*=T*/ n/*<T>*/() => null;
+  T m<T>(T s) => s;
+  T n<T>() => null;
 }
 void f() {
   dynamic d;
   int i;
   new C()./*error:IMPLICIT_DYNAMIC_METHOD*/m(d);
   new C().m(42);
   new C()./*error:IMPLICIT_DYNAMIC_METHOD*/n();
   d = new C()./*error:IMPLICIT_DYNAMIC_METHOD*/n();
   i = new C().n();
 
@@ skipping 1677 matching lines @@
   }
 }
 ''');
   }
 
   test_typePromotionFromTypeParameter() async {
     // Regression test for:
     // https://github.com/dart-lang/sdk/issues/26965
     // https://github.com/dart-lang/sdk/issues/27040
     await checkFile(r'''
-void f/*<T>*/(/*=T*/ object) {
+void f<T>(T object) {
   if (object is String) print(object.substring(1));
 }
-void g/*<T extends num>*/(/*=T*/ object) {
+void g<T extends num>(T object) {
   if (object is int) print(object.isEven);
   if (object is String) print(/*info:DYNAMIC_INVOKE*/object./*error:UNDEFINED_METHOD*/substring(1));
 }
 class Clonable<T> {}
 class SubClonable<T> extends Clonable<T> {
   T m(T t) => t;
 }
-void takesSubClonable/*<A>*/(SubClonable/*<A>*/ t) {}
+void takesSubClonable<A>(SubClonable<A> t) {}
 
-void h/*<T extends Clonable<T>>*/(/*=T*/ object) {
-  if (/*info:NON_GROUND_TYPE_CHECK_INFO*/object is SubClonable/*<T>*/) {
+void h<T extends Clonable<T>>(T object) {
+  if (/*info:NON_GROUND_TYPE_CHECK_INFO*/object is SubClonable<T>) {
     print(object.m(object));
 
-    SubClonable/*<T>*/ s = object;
-    takesSubClonable/*<T>*/(object);
+    SubClonable<T> s = object;
+    takesSubClonable<T>(object);
     h(object);
   }
 }
 ''');
   }
 
   test_typePromotionFromTypeParameterAndInference() async {
     // Regression test for:
     // https://github.com/dart-lang/sdk/issues/27040
     await checkFile(r'''
-void f/*<T extends num>*/(T x, T y) {
+void f<T extends num>(T x, T y) {
   var z = x;
   var f = () => x;
   f = () => y;
   if (x is int) {
     /*info:DYNAMIC_INVOKE*/z./*error:UNDEFINED_GETTER*/isEven;
     var q = x;
     q = /*info:DOWN_CAST_COMPOSITE*/z;
     /*info:DYNAMIC_INVOKE*/f()./*error:UNDEFINED_GETTER*/isEven;
 
     // This captures the type `T extends int`.
@@ skipping 268 matching lines @@
 class CheckerTest_Driver extends CheckerTest {
   @override
   bool get enableNewAnalysisDriver => true;
 
   @failingTest
   @override
   test_covariantOverride_fields() async {
     await super.test_covariantOverride_fields();
   }
 }