Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2990363002: Include passing tests in BuildResult.results (Closed)

Created:
3 years, 4 months ago by Johnni Winther
Modified:
3 years, 4 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -9 lines) Patch
M tools/gardening/lib/src/buildbot_loading.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/gardening/lib/src/buildbot_structures.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/gardening/lib/src/client.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gardening/lib/src/compare_failures_impl.dart View 1 chunk +1 line, -7 lines 0 comments Download
A tools/gardening/test/parse_build_results_test.dart View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 4 months ago (2017-08-08 12:05:17 UTC) #2
floitsch
LGTM.
3 years, 4 months ago (2017-08-08 13:22:52 UTC) #3
Johnni Winther
3 years, 4 months ago (2017-08-08 14:24:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c54869c648d37d85ab8b31128dbdb3d50c778355 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698