Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: tools/gardening/lib/src/client.dart

Issue 2990363002: Include passing tests in BuildResult.results (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:async'; 5 import 'dart:async';
6 import 'dart:io' hide HttpException; 6 import 'dart:io' hide HttpException;
7 7
8 import 'buildbot_data.dart'; 8 import 'buildbot_data.dart';
9 import 'buildbot_loading.dart'; 9 import 'buildbot_loading.dart';
10 import 'buildbot_structures.dart'; 10 import 'buildbot_structures.dart';
(...skipping 12 matching lines...) Expand all
23 } 23 }
24 24
25 /// Buildbot client that pulls build bot results through http. 25 /// Buildbot client that pulls build bot results through http.
26 class HttpBuildbotClient implements BuildbotClient { 26 class HttpBuildbotClient implements BuildbotClient {
27 final HttpClient _client = new HttpClient(); 27 final HttpClient _client = new HttpClient();
28 28
29 @override 29 @override
30 Future<BuildResult> readResult(BuildUri buildUri) async { 30 Future<BuildResult> readResult(BuildUri buildUri) async {
31 try { 31 try {
32 return await readBuildResultFromHttp(_client, buildUri); 32 return await readBuildResultFromHttp(_client, buildUri);
33 } on HttpException catch (e) { 33 } on HttpException {
34 return null; 34 return null;
35 } on SocketException catch (e) { 35 } on SocketException {
36 return null; 36 return null;
37 } 37 }
38 } 38 }
39 39
40 int get mostRecentBuildNumber => -2; 40 int get mostRecentBuildNumber => -2;
41 41
42 @override 42 @override
43 void close() { 43 void close() {
44 _client.close(); 44 _client.close();
45 } 45 }
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 buildUri = buildUri.withBuildNumber(buildNumber); 89 buildUri = buildUri.withBuildNumber(buildNumber);
90 } 90 }
91 } 91 }
92 } 92 }
93 93
94 @override 94 @override
95 void close() { 95 void close() {
96 // Nothing to do. 96 // Nothing to do.
97 } 97 }
98 } 98 }
OLDNEW
« no previous file with comments | « tools/gardening/lib/src/buildbot_structures.dart ('k') | tools/gardening/lib/src/compare_failures_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698