fix DDC buildbot so it is green

Fix DDC buildbot so it is green

This is an attempt to get DDC's bot (https://travis-ci.org/dart-lang/sdk) green and restore test coverage, without affecting the Analyzer --strong buildbot. DDC and Analyzer can generally use the same status entries, as they are running nearly identical strong mode analysis. This fixes DDC's test builder to understand status codes in the same way analyzer does, as that was causing mismatch in statuses.

This does not fix the problem that we're skipping tests instead of recording the status. So there is a bit of test coverage lost, but it restores most of DDC's coverage. We can tackle the skips either in a follow up, or as we migrate tests from *_strong to *_2.

This is a partial revert of  "Revert status file changes from 58a6227198d2aa927df19f1b4862f8d0017d6da4" in commit 7be946cf3d387fd74eb837211bc22c88288a6d20.

Committed: https://github.com/dart-lang/sdk/commit/676cf46c447577b71cae8c61f5f050837eedd038

[Jennifer Messerly, 2017-08-03 02:51:38]

Description was changed from

==========
Fixes DDC buildbot & keeps analyzer strong bot working

This is an attempt to get DDC's bot green

Revert "Revert status file changes from
58a6227198d2aa927df19f1b4862f8d0017d6da4"
This reverts commit 7be946cf3d387fd74eb837211bc22c88288a6d20.

BUG=
==========

to

==========
Fixes DDC buildbot

This is an attempt to get DDC's bot green and restore test coverage, without
affecting the Analyzer buildbot.

This does not fix the problem that we're skipping some tests that may in fact be
passing, so there is a bit of coverage lost, but that can be tackled as we
migrate tests from *_strong to *_2.

This is a partial revert of  "Revert status file changes from
58a6227198d2aa927df19f1b4862f8d0017d6da4" in commit
7be946cf3d387fd74eb837211bc22c88288a6d20.
==========

[Jennifer Messerly, 2017-08-03 02:53:25]

Description was changed from

==========
Fixes DDC buildbot

This is an attempt to get DDC's bot green and restore test coverage, without
affecting the Analyzer buildbot.

This does not fix the problem that we're skipping some tests that may in fact be
passing, so there is a bit of coverage lost, but that can be tackled as we
migrate tests from *_strong to *_2.

This is a partial revert of  "Revert status file changes from
58a6227198d2aa927df19f1b4862f8d0017d6da4" in commit
7be946cf3d387fd74eb837211bc22c88288a6d20.
==========

to

==========
Fix DDC buildbot so it is green

This is an attempt to get DDC's bot (https://travis-ci.org/dart-lang/sdk) green
and restore test coverage, without affecting the Analyzer --strong buildbot.

This does not fix the problem that we're skipping tests instead of recording the
status. So there is a bit of test coverage lost, but it restores most of DDC's
coverage. We can tackle the skips either in a follow up, or as we migrate tests
from *_strong to *_2.

This is a partial revert of  "Revert status file changes from
58a6227198d2aa927df19f1b4862f8d0017d6da4" in commit
7be946cf3d387fd74eb837211bc22c88288a6d20.
==========

[Jennifer Messerly, 2017-08-03 02:53:26]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[Jennifer Messerly, 2017-08-03 02:55:43]

Description was changed from

==========
Fix DDC buildbot so it is green

This is an attempt to get DDC's bot (https://travis-ci.org/dart-lang/sdk) green
and restore test coverage, without affecting the Analyzer --strong buildbot.

This does not fix the problem that we're skipping tests instead of recording the
status. So there is a bit of test coverage lost, but it restores most of DDC's
coverage. We can tackle the skips either in a follow up, or as we migrate tests
from *_strong to *_2.

This is a partial revert of  "Revert status file changes from
58a6227198d2aa927df19f1b4862f8d0017d6da4" in commit
7be946cf3d387fd74eb837211bc22c88288a6d20.
==========

to

==========
Fix DDC buildbot so it is green

This is an attempt to get DDC's bot (https://travis-ci.org/dart-lang/sdk) green
and restore test coverage, without affecting the Analyzer --strong buildbot. DDC
and Analyzer can generally use the same status entries, as they are running
nearly identical strong mode analysis. This fixes DDC's test builder to
understand status codes in the same way analyzer does, as that was causing
mismatch in statuses.

This does not fix the problem that we're skipping tests instead of recording the
status. So there is a bit of test coverage lost, but it restores most of DDC's
coverage. We can tackle the skips either in a follow up, or as we migrate tests
from *_strong to *_2.

This is a partial revert of  "Revert status file changes from
58a6227198d2aa927df19f1b4862f8d0017d6da4" in commit
7be946cf3d387fd74eb837211bc22c88288a6d20.
==========

[Jennifer Messerly, 2017-08-03 02:57:41]

I am going to TBR this as it should only affect DDC, and only serve the purpose
of gardening for our broken buildbot.

I verified Analyzer --strong with:

./tools/test.py -m release -r none -c dart2analyzer --strong lib_strong
corelib_strong language_strong lib_2 language_2 corelib_2

... and also the status changes can be inspected to see that they are not
affecting Analyzer entries (except to bring DDC and Analyzer into closer
alignment)

[Jennifer Messerly, 2017-08-03 02:58:03]

Description was changed from

==========
Fix DDC buildbot so it is green

This is an attempt to get DDC's bot (https://travis-ci.org/dart-lang/sdk) green
and restore test coverage, without affecting the Analyzer --strong buildbot. DDC
and Analyzer can generally use the same status entries, as they are running
nearly identical strong mode analysis. This fixes DDC's test builder to
understand status codes in the same way analyzer does, as that was causing
mismatch in statuses.

This does not fix the problem that we're skipping tests instead of recording the
status. So there is a bit of test coverage lost, but it restores most of DDC's
coverage. We can tackle the skips either in a follow up, or as we migrate tests
from *_strong to *_2.

This is a partial revert of  "Revert status file changes from
58a6227198d2aa927df19f1b4862f8d0017d6da4" in commit
7be946cf3d387fd74eb837211bc22c88288a6d20.
==========

to

==========
Fix DDC buildbot so it is green

This is an attempt to get DDC's bot (https://travis-ci.org/dart-lang/sdk) green
and restore test coverage, without affecting the Analyzer --strong buildbot. DDC
and Analyzer can generally use the same status entries, as they are running
nearly identical strong mode analysis. This fixes DDC's test builder to
understand status codes in the same way analyzer does, as that was causing
mismatch in statuses.

This does not fix the problem that we're skipping tests instead of recording the
status. So there is a bit of test coverage lost, but it restores most of DDC's
coverage. We can tackle the skips either in a follow up, or as we migrate tests
from *_strong to *_2.

This is a partial revert of  "Revert status file changes from
58a6227198d2aa927df19f1b4862f8d0017d6da4" in commit
7be946cf3d387fd74eb837211bc22c88288a6d20.

Committed:
https://github.com/dart-lang/sdk/commit/676cf46c447577b71cae8c61f5f050837eedd038
==========

[Jennifer Messerly, 2017-08-03 02:58:04]

Committed patchset #1 (id:1) manually as
676cf46c447577b71cae8c61f5f050837eedd038 (presubmit successful).