fix DDC buildbot so it is green

pkg/dev_compiler/test/codegen_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Tests code generation.
 ///
 /// Runs Dart Dev Compiler on all input in the `codegen` directory and checks
 /// that the output is what we expected.
 library dev_compiler.test.codegen_test;
 
@@ skipping 150 matching lines @@
       var exception, stackTrace;
       try {
         module = compiler.compile(unit, options);
       } catch (e, st) {
         exception = e;
         stackTrace = st;
       }
 
       // This covers tests where the intent of the test is to validate that
       // some static error is produced.
-      var intentionalCompileError = contents.contains(': compile-time error') ||
-          contents.contains('/*@compile-error=');
+      var intentionalCompileError =
+          (contents.contains(': compile-time error') ||
+                  contents.contains('/*@compile-error=')) &&
+              !status.contains(Expectation.missingCompileTimeError);
 
       var crashing = status.contains(Expectation.crash);
       if (module == null) {
         expect(crashing, isTrue,
             reason: "test $name crashes during compilation.\n"
                 "$exception\n$stackTrace");
         return;
       }
 
       // Write out JavaScript and/or compilation errors/warnings.
       _writeModule(
           path.join(codegenOutputDir, name),
           isTopLevelTest ? path.join(codegenExpectDir, name) : null,
           moduleFormat,
           module);
 
       expect(crashing, isFalse, reason: "test $name no longer crashes.");
 
-      var knownCompileError = status.contains(Expectation.compileTimeError);
+      var knownCompileError = status.contains(Expectation.compileTimeError) ||
+          status.contains(Expectation.fail);
+      // TODO(jmesserly): we could also invert negative_test, however analyzer
+      // in test.dart does not do this.
+      //   name.endsWith('negative_test') && !status.contains(Expectation.fail)
       if (module.isValid) {
         expect(knownCompileError, isFalse,
             reason: "test $name expected static errors, but compiled.");
       } else {
         var reason = intentionalCompileError ? "intended" : "unexpected";
         expect(intentionalCompileError || knownCompileError, isTrue,
             reason: "test $name failed to compile due to $reason errors:"
                 "\n\n${module.errors.join('\n')}.");
       }
     });
@@ skipping 66 matching lines @@
 }
 
 void _writeRuntimeStatus(Map<String, Set<Expectation>> testFiles) {
   var runtimeStatus = <String, String>{};
   testFiles.forEach((name, status) {
     name = path.withoutExtension(path.relative(name, from: codegenTestDir));
     // Skip tests that we don't expect to compile.
     if (status.contains(Expectation.compileTimeError) ||
         status.contains(Expectation.crash) ||
         status.contains(Expectation.skip) ||
+        status.contains(Expectation.fail) ||
         status.contains(Expectation.skipByDesign)) {
       return;
     }
     // Normalize the expectations for the Karma language_test.js runner.
     if (status.remove(Expectation.ok)) assert(status.isNotEmpty);
     if (status.remove(Expectation.missingCompileTimeError) ||
         status.remove(Expectation.missingRuntimeError)) {
       status.add(Expectation.pass);
     }
 
@@ skipping 158 matching lines @@
   StringLiteral uriLiteral = directive.uri;
   String uriContent = uriLiteral.stringValue;
   if (uriContent != null) {
     uriContent = uriContent.trim();
     directive.uriContent = uriContent;
   }
   return (directive as UriBasedDirectiveImpl).validate() == null
       ? uriContent
       : null;
 }