Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2990133002: [logdog] Don't promote dev upload. (Closed)

Created:
3 years, 4 months ago by dnj
Modified:
3 years, 4 months ago
Reviewers:
Ryan Tseng, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

[logdog] Don't promote dev upload. The Makefile forgot to set the "--no-promote" flag when uploading the dev static instance. TBR=hinoka@chromium.org BUG=None TEST=None Review-Url: https://codereview.chromium.org/2990133002 Committed: https://github.com/luci/luci-go/commit/379385244aafd8eaf3342455774d102f17263a45

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M logdog/appengine/cmd/coordinator/Makefile View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
dnj
3 years, 4 months ago (2017-08-01 22:30:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2990133002/1
3 years, 4 months ago (2017-08-01 22:30:04 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://github.com/luci/luci-go/commit/379385244aafd8eaf3342455774d102f17263a45
3 years, 4 months ago (2017-08-01 22:36:43 UTC) #6
Ryan Tseng
3 years, 4 months ago (2017-08-01 22:44:49 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698