Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2989943002: config_service: add link to go back to the front page (Closed)

Created:
3 years, 4 months ago by ayanaadylova
Modified:
3 years, 4 months ago
Reviewers:
Sergey Berezin, hinoka
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

config_service: add link to go back to the front page Made the "Configuration Service" page title a link to `/#/` URL. BUG=750008 Review-Url: https://codereview.chromium.org/2989943002 Committed: https://github.com/luci/luci-py/commit/adf9d26b64b1ae163283314aefe2e66427c7360b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M appengine/config_service/ui/src/config-ui/config-ui.html View 2 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
ayanaadylova
PTAL
3 years, 4 months ago (2017-07-28 18:02:27 UTC) #3
Sergey Berezin
LGTM, thanks!
3 years, 4 months ago (2017-07-31 18:40:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2989943002/1
3 years, 4 months ago (2017-07-31 18:52:39 UTC) #6
commit-bot: I haz the power
3 years, 4 months ago (2017-07-31 18:56:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/adf9d26b64b1ae163283314aefe2e66427c7360b

Powered by Google App Engine
This is Rietveld 408576698