Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2989833002: config_service: include type of config to the config-set card (Closed)

Created:
3 years, 4 months ago by ayanaadylova
Modified:
3 years, 4 months ago
Reviewers:
Sergey Berezin, hinoka
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

config_service: include type of config to the config-set card Included type of config service to make it easier to visually determine the type of config set. BUG=749533 Review-Url: https://codereview.chromium.org/2989833002 Committed: https://github.com/luci/luci-py/commit/d3bd7823b4fe248ccc7e513c1039b36e00d20dad

Patch Set 1 #

Patch Set 2 : Change config-set cards. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M appengine/config_service/ui/src/config-ui/config-set-card.html View 1 4 chunks +3 lines, -8 lines 0 comments Download
M appengine/config_service/ui/test/config-ui/config-set_test.html View 1 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
ayanaadylova
PTAL https://screenshot.googleplex.com/5OyePWSLin8
3 years, 4 months ago (2017-07-27 18:53:36 UTC) #2
Sergey Berezin
Code LGTM, though consider making the distinction even more obvious visually. The bug requests an ...
3 years, 4 months ago (2017-07-27 21:19:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2989833002/20001
3 years, 4 months ago (2017-07-27 22:33:48 UTC) #6
commit-bot: I haz the power
3 years, 4 months ago (2017-07-27 22:36:23 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/d3bd7823b4fe248ccc7e513c1039b36e00d20dad

Powered by Google App Engine
This is Rietveld 408576698