Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: packages/stack_trace/test/chain/dart2js_test.dart

Issue 2989763002: Update charted to 0.4.8 and roll (Closed)
Patch Set: Removed Cutch from list of reviewers Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « packages/stack_trace/test/chain/chain_test.dart ('k') | packages/stack_trace/test/chain/utils.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packages/stack_trace/test/chain/dart2js_test.dart
diff --git a/packages/stack_trace/test/chain/dart2js_test.dart b/packages/stack_trace/test/chain/dart2js_test.dart
index afb27fa046405523df4758a26bc3be4b81ad2996..df3d07bd9e7c5fe1862da73fd73b6692c970ab64 100644
--- a/packages/stack_trace/test/chain/dart2js_test.dart
+++ b/packages/stack_trace/test/chain/dart2js_test.dart
@@ -28,14 +28,14 @@ void main() {
});
test('thrown in a one-shot timer', () async {
- var chain = await captureFuture(
- () => inOneShotTimer(() => throw 'error'));
+ var chain =
+ await captureFuture(() => inOneShotTimer(() => throw 'error'));
expect(chain.traces, hasLength(2));
});
test('thrown in a periodic timer', () async {
- var chain = await captureFuture(
- () => inPeriodicTimer(() => throw 'error'));
+ var chain =
+ await captureFuture(() => inPeriodicTimer(() => throw 'error'));
expect(chain.traces, hasLength(2));
});
@@ -238,11 +238,11 @@ void main() {
});
});
- test('current() outside of capture() returns a chain wrapping the current '
+ test(
+ 'current() outside of capture() returns a chain wrapping the current '
'trace', () {
- // The test runner runs all tests with chains enabled, so to test without we
- // have to do some zone munging.
- return runZoned(() async {
+ // The test runner runs all tests with chains enabled.
+ return Chain.disable(() async {
var completer = new Completer();
inMicrotask(() => completer.complete(new Chain.current()));
@@ -251,7 +251,7 @@ void main() {
// chain isn't available and it just returns the current stack when
// called.
expect(chain.traces, hasLength(1));
- }, zoneValues: {#stack_trace.stack_zone.spec: null});
+ });
});
group('forTrace() within capture()', () {
@@ -282,7 +282,8 @@ void main() {
expect(chain.traces, hasLength(3));
});
- test('called for a stack trace from a nested series of asynchronous '
+ test(
+ 'called for a stack trace from a nested series of asynchronous '
'operations', () async {
var chain = await Chain.capture(() {
return chainForTrace((callback) {
@@ -301,7 +302,8 @@ void main() {
expect(chain.traces, hasLength(3));
});
- test('called for an unregistered stack trace returns a chain wrapping that '
+ test(
+ 'called for an unregistered stack trace returns a chain wrapping that '
'trace', () {
var trace;
var chain = Chain.capture(() {
@@ -319,7 +321,8 @@ void main() {
});
});
- test('forTrace() outside of capture() returns a chain wrapping the given '
+ test(
+ 'forTrace() outside of capture() returns a chain wrapping the given '
'trace', () {
var trace;
var chain = Chain.capture(() {
« no previous file with comments | « packages/stack_trace/test/chain/chain_test.dart ('k') | packages/stack_trace/test/chain/utils.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698