Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: packages/stack_trace/test/chain/utils.dart

Issue 2989763002: Update charted to 0.4.8 and roll (Closed)
Patch Set: Removed Cutch from list of reviewers Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « packages/stack_trace/test/chain/dart2js_test.dart ('k') | packages/stack_trace/test/chain/vm_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packages/stack_trace/test/chain/utils.dart
diff --git a/packages/stack_trace/test/chain/utils.dart b/packages/stack_trace/test/chain/utils.dart
index 1e19eeb3c64de393f843020c8f7e06ce479c0f05..bf821588df379fb753cf5f539f2f7f9f6ff691ab 100644
--- a/packages/stack_trace/test/chain/utils.dart
+++ b/packages/stack_trace/test/chain/utils.dart
@@ -2,8 +2,6 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-library stack_trace.test.chain.utils;
-
import 'dart:async';
import 'package:stack_trace/stack_trace.dart';
@@ -72,11 +70,15 @@ Future<Chain> chainForTrace(asyncFn(callback()), callback()) {
// [new Future.sync] because those methods don't pass the exception through
// the zone specification before propagating it, so there's no chance to
// attach a chain to its stack trace. See issue 15105.
- new Future.value().then((_) => callback())
+ new Future.value()
+ .then((_) => callback())
.catchError(completer.completeError);
});
+
+ // TODO(rnystrom): Remove this cast if catchError() gets a better type.
return completer.future
- .catchError((_, stackTrace) => new Chain.forTrace(stackTrace));
+ .catchError((_, stackTrace) => new Chain.forTrace(stackTrace))
+ as Future<Chain>;
}
/// Runs [callback] in a [Chain.capture] zone and returns a Future that
« no previous file with comments | « packages/stack_trace/test/chain/dart2js_test.dart ('k') | packages/stack_trace/test/chain/vm_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698